Page MenuHomeFreeBSD

Add newfstatat system call for 64-bit Linuxulator.
ClosedPublic

Authored by dchagin on Nov 1 2014, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 1:06 PM
Unknown Object (File)
Wed, Mar 6, 1:03 PM
Unknown Object (File)
Feb 1 2024, 3:17 PM
Unknown Object (File)
Jan 14 2024, 10:04 PM
Unknown Object (File)
Jan 5 2024, 5:36 PM
Unknown Object (File)
Dec 25 2023, 9:37 AM
Unknown Object (File)
Dec 20 2023, 12:29 AM
Unknown Object (File)
Dec 1 2023, 6:05 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin retitled this revision from to Add newfstatat system call for 64-bit Linuxulator..
trasz added inline comments.
sys/compat/linux/linux_stats.c
630 ↗(On Diff #2209)

#else /* what's the condition */

Also - where is it called from?

sys/compat/linux/linux_stats.c
630 ↗(On Diff #2209)
  1. see above #if defined(i386)....
  2. it's for 64-bit Linuxulator.
sys/compat/linux/linux_stats.c
630 ↗(On Diff #2209)

Still, would be nice to add the comment - something like /* !defined(i386) && (defined(amd64) && !defined(COMPAT_LINUX32)) /*. Also, I think the comment on the closing block (#endif) is wrong.

Ok, comment here! Bottom comment is right as it applies to the end of #if clause

trasz added a reviewer: trasz.
This revision is now accepted and ready to land.Mar 27 2015, 9:44 AM
dchagin edited edge metadata.

fix a typo.

This revision now requires review to proceed.Mar 29 2015, 8:59 AM
trasz edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2015, 12:08 PM
This revision was automatically updated to reflect the committed changes.