Differential D1071

Add newfstatat system call for 64-bit Linuxulator.
ClosedPublic
Actions

Authored by dchagin on Nov 1 2014, 2:02 PM.

Tags

None

Referenced Files

	F105972958: D1071.id.diff
	Mon, Dec 23, 7:24 AM

	Unknown Object (File)
	Wed, Dec 18, 4:10 AM

	Unknown Object (File)
	Wed, Dec 18, 3:22 AM

	Unknown Object (File)
	Mon, Dec 2, 8:14 AM

	Unknown Object (File)
	Nov 17 2024, 8:41 AM

	Unknown Object (File)
	Nov 10 2024, 11:32 AM

	Unknown Object (File)
	Nov 7 2024, 1:11 AM

	Unknown Object (File)
	Oct 25 2024, 3:37 PM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rS283420: Add newfstatat system call for 64-bit Linuxulator.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin updated this revision to Diff 2209.Nov 1 2014, 2:02 PM

dchagin retitled this revision from to Add newfstatat system call for 64-bit Linuxulator..

dchagin added a reviewer: Linux Emulation.Nov 2 2014, 9:37 PM

trasz added a subscriber: trasz.Mar 21 2015, 6:09 PM

trasz added inline comments.

sys/compat/linux/linux_stats.c
630 ↗	(On Diff #2209)	#else /* what's the condition */ Also - where is it called from?

style(9).

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2015, 6:36 PM

dchagin added inline comments.Mar 24 2015, 6:37 PM

sys/compat/linux/linux_stats.c
630 ↗	(On Diff #2209)	see above #if defined(i386).... it's for 64-bit Linuxulator.

trasz added inline comments.Mar 25 2015, 11:20 AM

sys/compat/linux/linux_stats.c
630 ↗	(On Diff #2209)	Still, would be nice to add the comment - something like /* !defined(i386) && (defined(amd64) && !defined(COMPAT_LINUX32)) /*. Also, I think the comment on the closing block (#endif) is wrong.

Ok, comment here! Bottom comment is right as it applies to the end of #if clause

trasz accepted this revision.Mar 27 2015, 9:44 AM

trasz added a reviewer: trasz.

This revision is now accepted and ready to land.Mar 27 2015, 9:44 AM

fix a typo.

This revision now requires review to proceed.Mar 29 2015, 8:59 AM

trasz accepted this revision.Mar 31 2015, 12:08 PM

trasz edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 12:08 PM

Closed by commit rS283420: Add newfstatat system call for 64-bit Linuxulator. (authored by dchagin). · Explain WhyMay 24 2015, 3:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

compat/

linux/

30 lines

Diff 5631

head/sys/compat/linux/linux_stats.c

Loading...