Page MenuHomeFreeBSD

Add a regression test for r318191
ClosedPublic

Authored by markj on May 11 2017, 5:07 PM.

Details

Summary

The test simply attempts to attach to a multi-threaded process in which
threads are blocked on a file lock and thus sleeping in an SBDRY
section.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj created this revision.May 11 2017, 5:07 PM
markj retitled this revision from Add a regression test for r318191. to Add a regression test for r318191.May 11 2017, 5:08 PM
markj added reviewers: jhb, badger.
badger added inline comments.May 12 2017, 1:04 AM
tests/sys/kern/ptrace_test.c
3059 ↗(On Diff #28249)

I think "./ptrace.XXXXXX" would be a better file path. I believe the test framework will clean up the working directory, whereas something in /tmp would be left if the test bails out before unlink()ing.

markj updated this revision to Diff 28270.May 12 2017, 4:43 PM
  • Create the tmpfile in the current directory.
markj added inline comments.May 12 2017, 4:43 PM
tests/sys/kern/ptrace_test.c
3059 ↗(On Diff #28249)

Thanks, fixed.

badger accepted this revision.May 12 2017, 5:40 PM
This revision is now accepted and ready to land.May 12 2017, 5:40 PM
This revision was automatically updated to reflect the committed changes.