Page MenuHomeFreeBSD

Make x11-themes/adwaita-qt[45] slave ports of x11-themes/adwaita-common and update to 0.99
ClosedPublic

Authored by tcberner on May 10 2017, 9:27 PM.

Details

Summary
  • Update to 0.99
  • Make them all slaves
  • Take maintainership

I think QT[45]_USES and QT[45]_PLIST could be somehow stuck into one, however the best thing I could come up with was ${OPTIONS_SLAVE}_USES=... which would however also set it for the -common port...

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner created this revision.May 10 2017, 9:27 PM
tcberner updated this revision to Diff 28213.May 10 2017, 9:34 PM

Combine USES and PLIST.. ok, did save one line...

tcberner updated this revision to Diff 28964.May 29 2017, 6:02 AM

Update to 1.0.

Is this change non-invasive enough for implicit?

rakuco accepted this revision.May 29 2017, 10:38 AM

lgtm

x11-themes/adwaita-common/Makefile
28 ↗(On Diff #28964)

At first this looks a bit confusing, as it appears you're doing COMMON_USES=cmake:outsource [...]. I think a comment clarifying what's being done here with ?= makes sense.

This revision is now accepted and ready to land.May 29 2017, 10:38 AM
This revision was automatically updated to reflect the committed changes.