Page MenuHomeFreeBSD

devel/sdl12: Add sndio backend
ClosedPublic

Authored by tobik on May 9 2017, 2:50 PM.
Tags
None
Referenced Files
F106159857: D10658.id28177.diff
Thu, Dec 26, 9:16 AM
Unknown Object (File)
Nov 4 2024, 3:03 PM
Unknown Object (File)
Oct 23 2024, 7:49 PM
Unknown Object (File)
Oct 12 2024, 8:39 PM
Unknown Object (File)
Oct 12 2024, 8:39 PM
Unknown Object (File)
Oct 12 2024, 8:39 PM
Unknown Object (File)
Oct 12 2024, 8:39 PM
Unknown Object (File)
Oct 12 2024, 3:26 AM
Subscribers
None

Details

Summary
Add sndio backend

While here

- Add LICENSE_FILE, USES=localbase
- Strip library
- Group audio backend options
- Use options helpers for VGL

Approved by:	??? (mentor)
Obtained from:	OpenBSD
Differential Revision:	https://reviews.freebsd.org/D?????
Test Plan

poudriere testport 10.3/i386 ok (SNDIO=on and SNDIO=off)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 9158
Build 9594: arc lint + arc unit

Event Timeline

devel/sdl12/files/patch-configure
39

I think this needs to be explained. OpenBSD regenerates the configure
script from configure.in after patching sndio detection into it.
However SDL 1.2 requires an older autoconf version (2.59) which is not
available on FreeBSD. Lots of errors when using autoconf 2.69.

Since I was unable to regenerate it I opted to edit configure
manually. So this does the bare minimum to wire the backend sources
into the build and make sure that SNDIO_CONFIGURE_ENABLE can do its
job in enabling/disabling sndio support.

Seems good. But please include the reasoning for the configure patch in the commit message.

This revision is now accepted and ready to land.May 30 2017, 2:52 PM
This revision was automatically updated to reflect the committed changes.