Page MenuHomeFreeBSD

devel/py-glob2: Update to 0.5
ClosedPublic

Authored by loader on May 9 2017, 7:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 11:28 AM
Unknown Object (File)
Feb 18 2024, 1:25 PM
Unknown Object (File)
Feb 18 2024, 1:14 PM
Unknown Object (File)
Feb 18 2024, 1:13 PM
Unknown Object (File)
Feb 18 2024, 1:13 PM
Unknown Object (File)
Feb 18 2024, 1:01 PM
Unknown Object (File)
Jan 27 2024, 9:16 AM
Unknown Object (File)
Jan 11 2024, 6:53 PM
Subscribers

Details

Summary

Proposed commit log message:

devel/py-glob2: Update to 0.5

- Add NO_ARCH
- Add LICENSE_FILE
- Add regression test
- Allow concurrent installation (USE_PYTHON=concurrent)

Reviewed_by: koobs
Approved by: koobs (ports)
Differential_Revision: D10652
Test Plan
# portlint -AC
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere log:
https://pastebin.com/raw/Cbip1vdN

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add USE_PYTHON=concurrent

loader retitled this revision from devel/py-glob2: update to 0.5 to devel/py-glob2: Update to 0.5.Jun 15 2017, 1:51 PM
loader edited the summary of this revision. (Show Details)
loader edited the test plan for this revision. (Show Details)

Looks good to me.

For future issues, formatting the TEST PLAN section of the review as follows is very helpful:

  • portlint: OK (looks fine. or WARNING: blah)
  • testport: OK (poudriere: <versions>, <archs>, <OPTIONS>, <python-versions> tested)
  • unittest: OK (PASS: 515 tests, skipped: X, failed: <num>) (or whatever the summary output is)
This revision is now accepted and ready to land.Jun 20 2017, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Looks good to me.

For future issues, formatting the TEST PLAN section of the review as follows is very helpful:

  • portlint: OK (looks fine. or WARNING: blah)
  • testport: OK (poudriere: <versions>, <archs>, <OPTIONS>, <python-versions> tested)
  • unittest: OK (PASS: 515 tests, skipped: X, failed: <num>) (or whatever the summary output is)

Hi @koobs, thanks for the tip. :-)