Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround issues on controllers with broken ACMD12 implementations.
ClosedPublic
Actions

Authored by loos on May 4 2017, 7:40 PM.

Details

Reviewers

mw_semihalf.com
jmcneill
imp
• ian

Commits

rS318095: Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround

Summary

Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround controllersthat do not support or have broken ACMD12 implementations.

Obtained from: Netbsd
Sponsored by: Rubicon Communications, LLC (Netgate)

Test Plan

Tested on ClearFog Pro (ARMADA38X)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9074
Build 9487: CI src build	Jenkins
Build 9486: arc lint + arc unit

Event Timeline

loos created this revision.May 4 2017, 7:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2017, 7:40 PM

loos retitled this revision from Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround controllers that do not support or have broken ACMD12 implementations. Obtained from: Netbsd Sponsored by: Rubicon Communications, LLC (Netgate) to Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround controllersthat do not support or have broken ACMD12 implementations.Obtained from: NetbsdSponsored by: Rubicon Communications, LLC (Netgate).May 4 2017, 7:41 PM

loos edited the test plan for this revision. (Show Details)

loos added reviewers: mw_semihalf.com, jmcneill, imp, • ian.

loos retitled this revision from Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround controllersthat do not support or have broken ACMD12 implementations.Obtained from: NetbsdSponsored by: Rubicon Communications, LLC (Netgate) to Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround issues on controllers with broken ACMD12 implementations..May 4 2017, 7:44 PM

loos edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B9074: Diff 28036.May 4 2017, 8:43 PM

loos mentioned this in D10606: Enable the SDHCI controller on ARMADA38X.May 5 2017, 3:18 AM

jmcneill accepted this revision.May 7 2017, 11:42 AM

This revision is now accepted and ready to land.May 7 2017, 11:42 AM

Closed by commit rS318095: Add a new SDHCI quirk, SDHCI_QUIRK_BROKEN_AUTO_STOP, to workaround (authored by loos). · Explain WhyMay 9 2017, 7:02 PM

This revision was automatically updated to reflect the committed changes.