Page MenuHomeFreeBSD

Bug 194584
ClosedPublic

Authored by jgh on Oct 31 2014, 9:22 PM.

Details

Reviewers
wblock
remko
bcr
Summary

poudriere(8) link in "Building Packages with Poudriere" doesn't point to a valid manpage

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jgh updated this revision to Diff 2192.Oct 31 2014, 9:22 PM
jgh retitled this revision from to Bug 194584.
jgh updated this object.
jgh edited the test plan for this revision. (Show Details)
jgh added reviewers: bcr, remko.
jgh added a comment.Oct 31 2014, 9:24 PM

The only item I wanted in this review was this patch:
en_US.ISO8859-1/books/handbook/ports/chapter.xml

Somehow previous ones are sneaking in....

wblock added a subscriber: wblock.Oct 31 2014, 9:32 PM

Only en_US.ISO8859-1/books/handbook/ports/chapter.xml reviewed.

en_US.ISO8859-1/books/handbook/ports/chapter.xml
1716

Avoid using "you", and the markup identifies a package: "after installing <package>ports-mgmt/poudriere</package>"

remko edited edge metadata.Oct 31 2014, 9:33 PM

There seems to be a space missing here:

details once you have installed the software package<package>
ports-mgmt/poudriere</package> or <package>
ports-mgmt/poudriere-devel</package>.</para>

The first line, after package, there should be a space.

However, we have multiple references to software that is not installed yet. I am not too shavvy that we need to add more words around that because then we need to do that allover.

I like the other changes :)

Remko

jgh updated this revision to Diff 2193.Oct 31 2014, 9:39 PM
jgh edited edge metadata.
wblock accepted this revision.Oct 31 2014, 10:03 PM
wblock added a reviewer: wblock.

I would lean towards "after" rather than "once", because "once" has multiple meanings ("after", and "one time"). But it is probably okay here.

This revision is now accepted and ready to land.Oct 31 2014, 10:03 PM
jgh closed this revision.Nov 5 2014, 7:02 PM