Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 26 2024, 10:43 PM
Unknown Object (File)
Dec 23 2023, 12:16 PM
Unknown Object (File)
Nov 21 2023, 7:33 PM
Unknown Object (File)
Nov 14 2023, 6:55 AM
Unknown Object (File)
Nov 11 2023, 11:19 PM
Unknown Object (File)
Oct 20 2023, 11:24 AM
Unknown Object (File)
Oct 19 2023, 6:18 PM
Unknown Object (File)
Aug 2 2023, 9:56 AM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.