Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
F151079543: D10562.diff
Sun, Apr 5, 8:32 PM
Unknown Object (File)
Sat, Apr 4, 4:54 PM
Unknown Object (File)
Fri, Apr 3, 10:10 PM
Unknown Object (File)
Sun, Mar 29, 7:43 AM
Unknown Object (File)
Fri, Mar 27, 2:52 AM
Unknown Object (File)
Mon, Mar 23, 1:40 AM
Unknown Object (File)
Jan 30 2026, 12:45 AM
Unknown Object (File)
Jan 29 2026, 11:28 AM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.