Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 6 2024, 5:08 AM
Unknown Object (File)
Dec 5 2024, 5:40 PM
Unknown Object (File)
Oct 8 2024, 7:31 AM
Unknown Object (File)
Sep 24 2024, 4:07 AM
Unknown Object (File)
Sep 23 2024, 9:30 AM
Unknown Object (File)
Sep 23 2024, 5:55 AM
Unknown Object (File)
Sep 20 2024, 5:27 AM
Unknown Object (File)
Sep 19 2024, 5:10 AM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.