Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 6:41 PM
Unknown Object (File)
Sat, Sep 19, 3:02 PM
Unknown Object (File)
Sun, Sep 6, 8:44 AM
Unknown Object (File)
Sun, Sep 6, 6:00 AM
Unknown Object (File)
Sat, Sep 5, 5:11 PM
Unknown Object (File)
Sat, Sep 5, 9:37 AM
Unknown Object (File)
Sep 3 2026, 10:09 PM
Unknown Object (File)
Sep 3 2026, 6:14 PM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.