Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
F170725753: D10562.id27893.diff
Sun, Sep 6, 6:00 AM
F170626520: D10562.diff
Sat, Sep 5, 5:11 PM
F170555151: D10562.diff
Sat, Sep 5, 9:37 AM
Unknown Object (File)
Thu, Sep 3, 10:09 PM
Unknown Object (File)
Thu, Sep 3, 6:14 PM
Unknown Object (File)
Wed, Sep 2, 10:08 PM
Unknown Object (File)
Wed, Sep 2, 7:30 AM
Unknown Object (File)
Wed, Sep 2, 2:46 AM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.