Page MenuHomeFreeBSD

loader.efi: ResetSystem does not use data with EFI_SUCCESS
ClosedPublic

Authored by tsoome on May 1 2017, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 5:52 AM
Unknown Object (File)
Tue, Sep 30, 1:01 AM
Unknown Object (File)
Sep 11 2025, 8:44 PM
Unknown Object (File)
Sep 6 2025, 7:18 AM
Unknown Object (File)
Aug 25 2025, 12:33 AM
Unknown Object (File)
Aug 15 2025, 2:57 AM
Unknown Object (File)
Aug 9 2025, 2:51 PM
Unknown Object (File)
Aug 5 2025, 5:00 PM
Subscribers

Details

Summary

The current reboot command in efi/loader/main.c is passing extra data with
ResetSystem, however, UEFI spec 2.6, page 265 does state:

"ResetData is only valid if ResetStatus is something other than EFI_SUCCESS
unless the ResetType is EfiResetPlatformSpecific where a minimum amount of
ResetData is always required."

Therefore we should use DataSize 0 and ResetData NULL - those are two last
arguments for the call.

Test Plan

Tested reboot command.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: emaste.

The CHAR16 * cast looks bogus anyhow

This revision is now accepted and ready to land.May 1 2017, 4:53 PM
This revision was automatically updated to reflect the committed changes.