Page MenuHomeFreeBSD

Fix Shebangs
ClosedPublic

Authored by tcberner on Apr 27 2017, 7:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 3:59 PM
Unknown Object (File)
Sun, Nov 10, 7:30 PM
Unknown Object (File)
Thu, Nov 7, 2:23 PM
Unknown Object (File)
Wed, Nov 6, 7:06 PM
Unknown Object (File)
Wed, Nov 6, 1:32 PM
Unknown Object (File)
Tue, Nov 5, 2:25 PM
Unknown Object (File)
Mon, Nov 4, 3:55 PM
Unknown Object (File)
Tue, Oct 29, 12:08 AM
Subscribers
None

Details

Summary
  • comms/gnuradio
  • graphics/hugin
  • math/asymptote - also modify patch-Makefile.in and post-patch, as one of the files is generated on the fly.
  • science/afni

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • x11-wm/fvwm2 - add PYTHON=${PYTHON_CMD} to the configure environment to fix shebangs
  • x11-wm/fvwm-crystal
devel/libdbusmenu/Makefile
25–32 ↗(On Diff #27808)

So you are adding python as a dependency so that a tool that nobody will ever use gets the right shebang ? It is ludicrous, please don't.

math/asymptote/files/patch-Makefile.in
16–17 ↗(On Diff #27808)

There is no real need for the patch, you could simply use /usr/bin/env python in the sed line in the Makefile.

x11-wm/fvwm2/Makefile
26–27 ↗(On Diff #27809)

Same here, it never needed python before, now it requires it to run ?

devel/libdbusmenu/Makefile
25–32 ↗(On Diff #27808)

according to INDEX it depends on python anyways, no?

So should this shebang error just be ignored?

devel/libdbusmenu/Makefile
25–32 ↗(On Diff #27808)

There are talks about reducing the pain for the python interpreter shebang thing, only if the port depends on python.

Now, if this already has python as a run dependencies through some dependency, it may be ok. Be sure to say so when you commit it.

  • Get rid of patch in math/asymptote
  • x11/mate-applets
  • math/kig - python is already an implicit run time dependency anyways.

Regenerate against current tree.

Looks ok, you might want to investigate using SHEBANG_REGEX or SHEBANG_GLOB in some cases.

This revision is now accepted and ready to land.May 3 2017, 10:15 AM
This revision was automatically updated to reflect the committed changes.