Differential D10525

crypto/openssl/ssl/srtp.h: Fix double removal
ClosedPublic
Actions

Authored by brnrd on Apr 27 2017, 2:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 16, 2:14 AM

	Unknown Object (File)
	Sat, Oct 11, 11:50 PM

	Unknown Object (File)
	Sat, Oct 11, 11:50 PM

	Unknown Object (File)
	Sat, Oct 11, 11:49 PM

	Unknown Object (File)
	Sat, Oct 11, 2:30 PM

	Unknown Object (File)
	Sat, Oct 11, 5:42 AM

	Unknown Object (File)
	Thu, Oct 9, 9:52 PM

	Unknown Object (File)
	Sun, Oct 5, 4:49 AM

View All 71 Files

Subscribers

Details

Reviewers

benl
jkim

Commits

rS328556: MFC: r328419
rS328419: Add declaration of SSL_get_selected_srtp_profile() for OpenSSL.

Summary

crypto/openssl/ssl/srtp.h: Fix double removal

 - SRTP_PROTECTION_PROFILE removed from code twice
 - See patch in [2]

[1] https://github.com/openssl/openssl/commit/383f0e349f0516440a37db29a6b81b8f6c49207f
[2] https://rt.openssl.org/Ticket/Display.html?id=2724

See also: D10523
Reported by: https://github.com/creytiv/re/issues/48

Test Plan

Tested in the port. When both lines removed, build fails with
-Werror -Qunused-arguments

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brnrd created this revision.Apr 27 2017, 2:07 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2017, 2:07 PM

Harbormaster completed remote builds in B8937: Diff 27784.Apr 27 2017, 2:43 PM

jkim accepted this revision.Jan 25 2018, 11:38 PM

This revision is now accepted and ready to land.Jan 25 2018, 11:38 PM

Closed by commit rS328419: Add declaration of SSL_get_selected_srtp_profile() for OpenSSL. (authored by jkim). · Explain WhyJan 25 2018, 11:38 PM

This revision was automatically updated to reflect the committed changes.

It'll be MFC'd to all stable branches in 3 days. Sorry for the delay.

Revision Contents
Changeset List

Path

Size

head/

crypto/

openssl/

ssl/

1 line

Diff 38465

head/crypto/openssl/ssl/srtp.h

Loading...