Differential D1048

Sched_rr_get_interval returns EINVAL in case when invalid pid specified. This silence the ltp tests.
ClosedPublic
Actions

Authored by dchagin on Oct 31 2014, 6:44 AM.

Tags

None

Referenced Files

	F106270764: D1048.diff
	Sat, Dec 28, 7:24 AM

	Unknown Object (File)
	Wed, Dec 18, 4:10 AM

	Unknown Object (File)
	Wed, Dec 18, 3:22 AM

	Unknown Object (File)
	Sat, Nov 30, 10:21 PM

	Unknown Object (File)
	Thu, Nov 28, 12:31 PM

	Unknown Object (File)
	Thu, Nov 28, 12:31 PM

	Unknown Object (File)
	Thu, Nov 28, 12:31 PM

	Unknown Object (File)
	Thu, Nov 28, 12:31 PM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rS283398: Sched_rr_get_interval returns EINVAL in case when the invalid pid

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

dchagin updated this revision to Diff 2178.Oct 31 2014, 6:44 AM

dchagin retitled this revision from to Sched_rr_get_interval returns EINVAL in case when invalid pid specified. This silence the ltp tests..

dchagin added a reviewer: Linux Emulation.Oct 31 2014, 6:58 AM

trasz added a subscriber: trasz.Dec 5 2014, 10:55 AM

trasz added inline comments.

sys/compat/linux/linux_misc.c
1949	Can you add a comment above explaining the purpose of this check?

dchagin added inline comments.Dec 8 2014, 11:33 AM

sys/compat/linux/linux_misc.c
1949	This is typical check to shut up LTP test as instead of EINVAL we returns ESRCH. According to man 2 sched_rr_get_interval should return EINVAL in case invalid pid specified.

trasz accepted this revision.Dec 8 2014, 12:13 PM

trasz added a reviewer: trasz.

trasz added inline comments.

sys/compat/linux/linux_misc.c
1949	Ok. Still, it would be nice to have this inside the comment. No biggie, though.

This revision is now accepted and ready to land.Dec 8 2014, 12:13 PM

inline comment added.

This revision now requires review to proceed.Jan 7 2015, 8:12 AM

trasz accepted this revision.Mar 21 2015, 5:15 PM

trasz edited edge metadata.

This revision is now accepted and ready to land.Mar 21 2015, 5:15 PM

Closed by commit rS283398: Sched_rr_get_interval returns EINVAL in case when the invalid pid (authored by dchagin). · Explain WhyMay 24 2015, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

3 lines

Diff 2178

sys/compat/linux/linux_misc.c

Loading...