Page MenuHomeFreeBSD

Add *.rc to shebangfix whitelist
ClosedPublic

Authored by AMDmi3 on Apr 19 2017, 10:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:47 AM
Unknown Object (File)
Dec 12 2023, 1:52 AM
Unknown Object (File)
Dec 9 2023, 7:36 PM
Unknown Object (File)
Oct 29 2023, 8:44 PM
Unknown Object (File)
Oct 27 2023, 10:22 PM
Unknown Object (File)
Oct 25 2023, 4:45 PM
Unknown Object (File)
Oct 21 2023, 11:44 PM
Unknown Object (File)
Jul 27 2023, 10:35 AM
Subscribers

Details

Summary

There are #!/bin/rc files installed by e.g. go:

Error: '/bin/rc' is an invalid shebang you need USES=shebangfix for 'go/src/all.rc'
Error: '/bin/rc' is an invalid shebang you need USES=shebangfix for 'go/src/clean.rc'
Error: '/bin/rc' is an invalid shebang you need USES=shebangfix for 'go/src/make.rc'
Error: '/bin/rc' is an invalid shebang you need USES=shebangfix for 'go/src/run.rc'

I'm not sure if these are usable on FreeBSD at all. We could add a shebangfix for them to use ${LOCALBASE}/bin/rc or whitelist them in qa.sh, and for now let's go the latter way.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8794
Build 9157: arc lint + arc unit

Event Timeline

We don't seem to have a bin/rc in our go ports, so, yeah, go ahead.

This revision is now accepted and ready to land.Apr 19 2017, 11:10 AM

There is no /bin/rc, so the warning is correct, or am I missing something?

I wonder if, instead, bin/rc should not be whitelisted.

AMDmi3 edited edge metadata.

Agreed with mat@ suggestion, whitelist /bin/rc instead

This revision now requires review to proceed.Apr 20 2017, 3:44 PM
This revision is now accepted and ready to land.Apr 20 2017, 9:57 PM

After committing this, please unfix lang/go14 :-)

This revision was automatically updated to reflect the committed changes.

Because of name collision, that change masks potential shebang error in devel/plan9port which depends on shells/rc (plan9-like shell) which provides bin/rc.
It's one obscure port, so I guess that change is ok, but it would be nice to at least add comment about this potential issue.