Page MenuHomeFreeBSD

textproc/apache-solr do not use lsof in startup script
ClosedPublic

Authored by ler on Apr 18 2017, 1:11 AM.

Details

Summary

Stock apache-solr scripts use lsof during startup to check if Solr started properly.

When deploying Apache Solr in Jail lsof needs access to /dev/mem which is not allowed by default. Lack of the access makes the startup script run in the loop for 3 minutes and then it assumes that it might have succeed.

Allowing access to /dev/mem makes running Solr in Jail a bit pointless.

Following patch changes the behaviour of Solr startup script to use sockstat instead of lsof to check if Solr has already started. This also makes the dependency on lsof obsolete.

PR: 218654
Submitted by: Wiktor Niesiobedzki <bsd@vink.pl>
Approved by: idefix@fechner.net (maintainer), (adamw|rene) (mentor)

Test Plan

poudriere (ok)
portlint (existing warnings)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Wow that is a much better method! Looks good, and good catch on the RUN_DEPENDS location. Do add something like "While here, pet portlint" to the commit message.

This revision is now accepted and ready to land.Apr 18 2017, 1:33 AM
This revision was automatically updated to reflect the committed changes.