Fix build with LLD by removing duplicate symbols already in IBVERBS_1.0.
ClosedPublic
Actions

Authored by bdrewery on Apr 10 2017, 6:44 PM.

Details

Reviewers

emaste

Commits

rS316690: Fix build with LLD by removing duplicate symbols already in IBVERBS_1.0.

Summary

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8667
Build 8994: arc lint + arc unit

Event Timeline

bdrewery created this revision.Apr 10 2017, 6:44 PM

Harbormaster completed remote builds in B8667: Diff 27317.Apr 10 2017, 6:44 PM

bdrewery added a reviewer: emaste.Apr 10 2017, 6:44 PM

Can you confirm that GNU ld handles the duplicates in the same way (keeping the first definition)?

This revision is now accepted and ready to land.Apr 10 2017, 6:47 PM

In D10352#214381, @emaste wrote:

Can you confirm that GNU ld handles the duplicates in the same way (keeping the first definition)?

From my amd64 build:

~/git/freebsd # readelf -a OBJ/contrib/ofed/usr.lib/libibverbs/libibverbs.so.1|grep @IBVERB|egrep '(ibv_get_device_list|ibv_free_device_list|ibv_get_device_name|ibv_get_device_guid|ibv_open_device|ibv_close_device)'
    72: 0000000000007dc0   166 FUNC    GLOBAL DEFAULT   12 ibv_get_device_guid@@IBVERBS_1.0 (2)
    73: 0000000000007e70   183 FUNC    GLOBAL DEFAULT   12 ibv_open_device@@IBVERBS_1.0 (2)
    83: 0000000000007da0    10 FUNC    GLOBAL DEFAULT   12 ibv_free_device_list@@IBVERBS_1.0 (2)
   105: 0000000000007f30   112 FUNC    GLOBAL DEFAULT   12 ibv_close_device@@IBVERBS_1.0 (2)
   106: 0000000000007db0    10 FUNC    GLOBAL DEFAULT   12 ibv_get_device_name@@IBVERBS_1.0 (2)
   109: 0000000000007ce0   186 FUNC    GLOBAL DEFAULT   12 ibv_get_device_list@@IBVERBS_1.0 (2)

Closed by commit rS316690: Fix build with LLD by removing duplicate symbols already in IBVERBS_1.0. (authored by bdrewery). · Explain WhyApr 10 2017, 9:26 PM

This revision was automatically updated to reflect the committed changes.

emaste mentioned this in D10428: libstdc++: fix up symbol version script.Apr 19 2017, 5:39 PM