sysutils/p5-Giovanni: a perl-based software deployment tool inspired by capistrano - v1.12

[ler]

Summary

sysutils/p5-Giovanni: a perl-based software deployment tool inspired by capistrano - v1.12

Giovanni is a Perl replacement for the idea behind Capistrano.
It is a deployment system that can be used comfortably from the
commandline to check out code, restart systems and notify.

PR: 218373
Submitted by: Dave Cottlehuber <[e-mail]>
Approved By: (adamw|rene) (mentor)

Test Plan

port lint (clean)
Poudriere (12, clean)

[adamw]

"add new port" isn't the right commit message. Your sentences must start with a capital latter. And new ports typically get the information from pkg-descr in the commit message.

sysutils/p5-Giovanni/Makefile

13 ↗

(On Diff #27068)

This license is wrong. "you can redistribute it and/or modify it under the same terms as the Perl 5 programming language system itself." Take a look at lang/perl5.24/Makefile and use the license info in there.

22 ↗

(On Diff #27068)

This looks way too indented.

[ler]

update the patch per @adamw's comments.

[adamw]

Virtualbox patches seem to be included here, and you haven't changed the commit message.

[adamw]

Oops, spoke too soon on the commit message!

[adamw]

Looks good. Go for it, just don't commit the vbox stuff.