Page MenuHomeFreeBSD

amlogic PIC changes for INTRNG
AcceptedPublic

Authored by john-feith.com on Apr 4 2017, 4:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 23 2024, 5:15 PM
Unknown Object (File)
Dec 22 2023, 11:52 PM
Unknown Object (File)
Nov 12 2023, 3:27 AM
Unknown Object (File)
Nov 11 2023, 6:04 AM
Unknown Object (File)
Oct 11 2023, 2:57 AM
Unknown Object (File)
Oct 10 2023, 5:05 AM
Unknown Object (File)
May 28 2023, 12:07 AM
Unknown Object (File)
Apr 8 2023, 5:01 AM
Subscribers

Details

Reviewers
ganbold
andrew
Summary

Here are the changes for the amlogic PIC interrupt controller present on the older aml8726-m3 chip.
The controller is also present on the aml8726-m6, however doesn't need to be used as that chip * also * has
a GIC.

Test Plan

Smoke tested on both aml8726-m3 and and aml8726-m6.

Prior to making this change in Dec 2016 I update to a current source tree ... at that time I noticed occasionally losing hardclock interrupts
on the older amlogic chips which use the PIC controller. I don't believe the problem occurred when I did the original port, however I haven't
gotten around to tracking down what's going on. This same problem is present after this update ... which to say it's no better / no worse.
However this update does provide INTRNG support which is an improvement.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Apr 16 2017, 8:58 AM
sys/arm/amlogic/aml8726/aml8726_pic.c
209

The indentation here looks off.

410

This should be BUS_PASS_INTERRUPT + BUS_PASS_ORDER_MIDDLE

sys/arm/conf/AML8726
27

This seems unrelated