Documentation for discovery-filter.

[trasz]

Summary

This is a piece of patch that adds discovery-filter to ctl.conf(5).

[bcr]

Looks good to me.

[wblock]

ctl.conf.5

205 ↗

(On Diff #2135)

I would prefer to break this long sentence.

and authentication credentials.
That is, if the target does not require CHAP authentication, or if CHAP user and secret are used during discovery, both CHAP user and secret are required to match to access the target.

[trasz]

ctl.conf.5

205 ↗

(On Diff #2135)

Hm, that's not quite what I meant. What I'm trying to say is, the access will be allowed if 1. target doesn't require authentication, or 2. target does require it, and authentication credentials during discovery match those of the target.

[wblock]

ctl.conf.5

205 ↗

(On Diff #2135)

That is a much clearer statement. Maybe:

and authentication credentials.
Access to the target is allowed if the target does not require CHAP authentication.
If authentication is required, CHAP user and secret must be supplied and match those used during discovery.

[trasz]

ctl.conf.5

205 ↗

(On Diff #2135)

I'm not sure if I'd understand this correctly if I didn't already know what it does.

How about this:

The target will be returned if it doesn't require CHAP authentication, or if CHAP user and secret used during discovery match those of the target.

[wblock]

ctl.conf.5

205 ↗

(On Diff #2135)

Minor adjustment:

The target is returned if it does not require CHAP authentication, or if the CHAP user and secret used during discovery match those used by the target.

[trasz]

Closed by commit rS274278 (authored by @trasz).