Page MenuHomeFreeBSD

new port: java/lightweight-java-profiler
ClosedPublic

Authored by jmd on Mar 30 2017, 5:12 AM.

Details

Summary

A port of the lightweight-java-profiler (ljp). ljp acts as a bare-bones agentlib to produce profiling stacks that can be digested, e.g., by Brendan Gregg's flamegraph scripts.

Test Plan

poudriere tested on 10.3, 11.0, HEAD amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

java/lightweight-java-profiler/Makefile
18 ↗(On Diff #26805)

This is not true, upstream says:

It defaults to a 32-bit build; it will place the resulting liblagent.so file in the build-32 directory; if you want to have a 64-bit build, say "make BITS=64 all" instead.

You could easily support both 32 and 64 bits builds.

Also, it says nothing about working only on x86, maybe it works on arm, mips...

Also enable assembly for i386, mark port only for archs amd64/i386 accordingly.

jmd marked an inline comment as done.Apr 1 2017, 2:08 AM
jmd added inline comments.
java/lightweight-java-profiler/Makefile
18 ↗(On Diff #26805)

It has inline assembly only for i386 and amd64. I think that rules out arm, mips, ... :-)

java/lightweight-java-profiler/Makefile
18 ↗(On Diff #26805)

Then the message should not be "only builds and is supported on i386/amd64", which is already what ONLY_FOR_ARCH=amd64 i386 says, but "contains inline x86 assembly"

jmd marked 2 inline comments as done.Apr 1 2017, 2:19 PM

Update wording of ONLY_FOR_ARCH_REASONS to be more explicit.

jmd marked an inline comment as done.Apr 1 2017, 5:26 PM
This revision is now accepted and ready to land.Apr 1 2017, 5:27 PM
This revision was automatically updated to reflect the committed changes.