new port: java/lightweight-java-profiler
ClosedPublic
Actions

Authored by jmd on Mar 30 2017, 5:12 AM.

Details

Reviewers

rene
swills

Commits

rP437452: new port: java/lightweight-java-profiler

Summary

A port of the lightweight-java-profiler (ljp). ljp acts as a bare-bones agentlib to produce profiling stacks that can be digested, e.g., by Brendan Gregg's flamegraph scripts.

Test Plan

poudriere tested on 10.3, 11.0, HEAD amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmd created this revision.Mar 30 2017, 5:12 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 30 2017, 5:12 AM

mat added inline comments.Mar 30 2017, 6:56 AM

java/lightweight-java-profiler/Makefile
18 ↗	(On Diff #26805)	This is not true, upstream says: It defaults to a 32-bit build; it will place the resulting liblagent.so file in the build-32 directory; if you want to have a 64-bit build, say "make BITS=64 all" instead. You could easily support both 32 and 64 bits builds. Also, it says nothing about working only on x86, maybe it works on arm, mips...

Also enable assembly for i386, mark port only for archs amd64/i386 accordingly.

jmd marked an inline comment as done.Apr 1 2017, 2:08 AM

jmd added inline comments.

java/lightweight-java-profiler/Makefile
18 ↗	(On Diff #26805)	It has inline assembly only for i386 and amd64. I think that rules out arm, mips, ... :-)

mat added inline comments.Apr 1 2017, 9:39 AM

java/lightweight-java-profiler/Makefile
18 ↗	(On Diff #26805)	Then the message should not be "only builds and is supported on i386/amd64", which is already what `ONLY_FOR_ARCH=amd64 i386` says, but "contains inline x86 assembly"