Page MenuHomeFreeBSD

Change how Perl modules are installed
ClosedPublic

Authored by mat on Oct 28 2014, 2:06 PM.

Details

Reviewers
mat
Group Reviewers
portmgr
Perl
Summary

Currently, we install modules which are not versionned at all in a versionned way:

site_perl :      lib/perl5/site_perl/5.18
site_perl_arch : lib/perl5/site_perl/5.18/mach

This changes the layout to:

site_perl :      lib/perl5/site_perl
site_perl_arch : lib/perl5/site_perl/mach/5.18

Allows to have all modules without any .so installed at the same place
whatever the Perl version is, and allows to have versionned versions of the
modules with .so.

Introduce a new plist replacement, SITE_ARCH, containing SITE_PERL/PERL_ARCH/PERL_VER

Remove perllocal.pod from Mk/Uses/perl5.mk, and cleanup ports installing/removing it.

Test Plan

exp-run to hell

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mat retitled this revision from to Change how Perl modules are installed.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: Perl, portmgr.
mat edited edge metadata.

With Perl 5.18 actually building.

I really like this one :)

Toss in a few converted ports.

mat edited the test plan for this revision. (Show Details)

Centralize removing perllocal.pod

Add all ports from the lang category.

The full patch is available at:
https://people.freebsd.org/~mat/patches/new-perl-order.diff

antoine added inline comments.
Mk/Uses/perl5.mk
99

why ${PERL_ARCH}/${PERL_VER} and not ${PERL_VER}/${PERL_ARCH} ?

Mk/Uses/perl5.mk
99

Well, that way, all of perl .so end up in ${PERL_ARCH} with on subdirectory for each perl version.

Be kind to our users and keep the old directories in @INC.

For all Perl versions.

Finaly, remove .packlist files.

Add three @dir that should stay.

Add CHANGES and UPDATING to the review.

Enhance the texts a bit.

Mk/bsd.port.mk
5968

I moved the Perl bits before post-install so that ports doing auto-plist in there don't catch files that will be removed afterwards.

brueffer added inline comments.
CHANGES
27

s/whatever the Perl version is/regardless of the Perl version/

40

"...these old Perl..." Perl versions perhaps?

Mk/Uses/perl5.mk
289

s/no/to/

UPDATING
17

s/another/a different/

29

5.18 I suppose?

mat added a reviewer: mat.
This revision is now accepted and ready to land.Nov 26 2014, 1:27 PM