Page MenuHomeFreeBSD

Bring Porters Handbook up to date and fix small errors. CH 3
ClosedPublic

Authored by ak on Oct 27 2014, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 2 2024, 5:18 PM
Unknown Object (File)
Dec 19 2023, 10:38 PM
Unknown Object (File)
Nov 18 2023, 9:54 PM
Unknown Object (File)
Nov 18 2023, 4:35 AM
Unknown Object (File)
Nov 18 2023, 2:48 AM
Unknown Object (File)
Nov 14 2023, 8:27 PM
Unknown Object (File)
Oct 13 2023, 7:27 PM
Unknown Object (File)
Aug 3 2023, 11:03 PM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
rD52776: Fix smallish errors.
Summary
  • Add closing bracket and change wording slightly
  • Use check-plist instead of check-orphans as more preferred target
  • Update package format to pkgng one
  • Update link to open ports prs

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ak retitled this revision from to Bring Porters Handbook up to date and fix small errors. CH 3.
ak updated this object.
ak edited the test plan for this revision. (Show Details)
ak added reviewers: portmgr, doceng.
ak set the repository for this revision to rD FreeBSD doc repository - subversion.
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/quick-porting/chapter.xml
388 ↗(On Diff #2119)

That is somewhat wrong, I don't think we should hardcode such urls, it would be better to tell people to go to /bugzilla and where to click.

That is somewhat wrong, I don't think we should hardcode such urls, it would be better to tell people to go to /bugzilla and where to click.

While it looks somewhat ugly, this url is stable and shouldn't change in observable future. So it's convenience versus aesthetics.

Is there a reason doceng@ is added, instead of a more wider audience?

I see no reason for doceng@ to be involved in review of such a trivial change.

ak set the repository for this revision to rD FreeBSD doc repository - subversion.
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/quick-porting/chapter.xml
133 ↗(On Diff #2119)

The colon was used as a vertical ellipsis there (...). It might be reasonable to replace it with a real ellipsis or an explanation:

the screen.
<replaceable>...additional description lines...</replaceable>

WWW: http://www.oneko.org/</programlisting>

145 ↗(On Diff #2119)

No whitespace after the paren, put it on the next line.

388 ↗(On Diff #2119)

The parameters could change, yes.

  • Use check-plist instead of check-orphans as more preferred target
  • Update package format to pkgng one
This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2019, 8:16 AM
Closed by commit rD52776: Fix smallish errors. (authored by mat). · Explain Why
This revision was automatically updated to reflect the committed changes.