Fix runtime PR: 217945 Submitted by: Masayoshi Fujimoto <m.fujimoto@yandex.ru> Reviewed by: Masayoshi Fujimoto <m.fujimoto@yandex.ru> Approved by: ??? (mentor) Differential Revision: https://reviews.freebsd.org/D?????
Details
Details
- Reviewers
lme mat - Commits
- rP436760: Fix runtime
poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Mmmm, the patch-xosmulti.c file has wrong properties, I don't know how you got them all to fit, but you should remove the MIME Type and the File Size one, and then, only one of fbsd:nokeywords and svn:keywords can be set.
Comment Actions
Sorry, in patch-xosmulti.c there are some EUC-JIS-2004 (I think!) encoded code comments and Arcanist only let me submit it as a binary file. I'm unsure how to fix this. I've uploaded the patch here as well: https://pkg.tobik.me/patches/xosmulti.diff
Comment Actions
I fixed the properties and updated the diff at https://pkg.tobik.me/patches/xosmulti.diff.
Comment Actions
Ah, yeah, phabricator only speaks UTF-8... (it must be nice to live in the facebook world where everything is always consistent)
Anyway, the properties in the patch looks kinda ok, maybe the svn:mime-type property is needed (I was only talking about the "MIME Type" field in here, maybe phabricator added it)