Page MenuHomeFreeBSD

games/xosmulti: Fix runtime
ClosedPublic

Authored by tobik on Mar 23 2017, 8:34 AM.

Details

Reviewers
lme
mat
Commits
rP436760: Fix runtime
Summary
Fix runtime

PR:		217945
Submitted by:	Masayoshi Fujimoto <m.fujimoto@yandex.ru>
Reviewed by:	Masayoshi Fujimoto <m.fujimoto@yandex.ru>
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D?????
Test Plan

poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Mar 23 2017, 8:34 AM
mat edited edge metadata.Mar 23 2017, 8:43 AM

Mmmm, the patch-xosmulti.c file has wrong properties, I don't know how you got them all to fit, but you should remove the MIME Type and the File Size one, and then, only one of fbsd:nokeywords and svn:keywords can be set.

tobik added a comment.Mar 23 2017, 8:45 AM

Sorry, in patch-xosmulti.c there are some EUC-JIS-2004 (I think!) encoded code comments and Arcanist only let me submit it as a binary file. I'm unsure how to fix this. I've uploaded the patch here as well: https://pkg.tobik.me/patches/xosmulti.diff

tobik added a comment.EditedMar 23 2017, 8:47 AM
In D10116#209099, @mat wrote:

Mmmm, the patch-xosmulti.c file has wrong properties, I don't know how you got them all to fit, but you should remove the MIME Type and the File Size one, and then, only one of fbsd:nokeywords and svn:keywords can be set.

Arcanist added them all on its own. Maybe this is related to the encoding problem?

tobik added a comment.Mar 23 2017, 8:58 AM

I fixed the properties and updated the diff at https://pkg.tobik.me/patches/xosmulti.diff.

mat accepted this revision.Mar 23 2017, 9:08 AM

Ah, yeah, phabricator only speaks UTF-8... (it must be nice to live in the facebook world where everything is always consistent)
Anyway, the properties in the patch looks kinda ok, maybe the svn:mime-type property is needed (I was only talking about the "MIME Type" field in here, maybe phabricator added it)

This revision is now accepted and ready to land.Mar 23 2017, 9:08 AM
This revision was automatically updated to reflect the committed changes.