Page MenuHomeFreeBSD

games/xosmulti: Fix runtime
ClosedPublic

Authored by tobik on Mar 23 2017, 8:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 2:07 AM
Unknown Object (File)
Wed, Oct 1, 1:16 AM
Unknown Object (File)
Mon, Sep 29, 12:13 AM
Unknown Object (File)
Sun, Sep 28, 2:55 AM
Unknown Object (File)
Thu, Sep 25, 11:48 AM
Unknown Object (File)
Wed, Sep 24, 3:10 AM
Unknown Object (File)
Thu, Sep 18, 8:26 PM
Unknown Object (File)
Thu, Sep 18, 7:44 PM
Subscribers
None

Details

Reviewers
lme
mat
Commits
rP436760: Fix runtime
Summary
Fix runtime

PR:		217945
Submitted by:	Masayoshi Fujimoto <m.fujimoto@yandex.ru>
Reviewed by:	Masayoshi Fujimoto <m.fujimoto@yandex.ru>
Approved by:	??? (mentor)
Differential Revision:	https://reviews.freebsd.org/D?????
Test Plan

poudriere testport 11.0/amd64 ok
poudriere testport 10.3/i386 ok

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mmmm, the patch-xosmulti.c file has wrong properties, I don't know how you got them all to fit, but you should remove the MIME Type and the File Size one, and then, only one of fbsd:nokeywords and svn:keywords can be set.

Sorry, in patch-xosmulti.c there are some EUC-JIS-2004 (I think!) encoded code comments and Arcanist only let me submit it as a binary file. I'm unsure how to fix this. I've uploaded the patch here as well: https://pkg.tobik.me/patches/xosmulti.diff

In D10116#209099, @mat wrote:

Mmmm, the patch-xosmulti.c file has wrong properties, I don't know how you got them all to fit, but you should remove the MIME Type and the File Size one, and then, only one of fbsd:nokeywords and svn:keywords can be set.

Arcanist added them all on its own. Maybe this is related to the encoding problem?

Ah, yeah, phabricator only speaks UTF-8... (it must be nice to live in the facebook world where everything is always consistent)
Anyway, the properties in the patch looks kinda ok, maybe the svn:mime-type property is needed (I was only talking about the "MIME Type" field in here, maybe phabricator added it)

This revision is now accepted and ready to land.Mar 23 2017, 9:08 AM
This revision was automatically updated to reflect the committed changes.