Page MenuHomeFreeBSD

[net/libzmq4] Re-add the split out cppzmq header files
Needs ReviewPublic

Authored by gergely.czuczy_harmless.hu on Mar 22 2017, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 3:56 AM
Unknown Object (File)
Mar 2 2024, 2:42 PM
Unknown Object (File)
Feb 11 2024, 11:35 AM
Unknown Object (File)
Jan 29 2024, 5:49 AM
Unknown Object (File)
Dec 29 2023, 4:39 PM
Unknown Object (File)
Dec 22 2023, 7:55 AM
Unknown Object (File)
Dec 21 2023, 4:34 PM
Unknown Object (File)
Dec 20 2023, 5:33 AM
Subscribers

Details

Reviewers
koobs
Summary

ACcording to http://zeromq.org/bindings:cpp, the C++ header files had been split out from zeromq. As discussed with koobs@, re-adding these header files seems to be the most convinient way, since they used to be part of the distribution, so people might expect them to be there.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8215
Build 8452: arc lint + arc unit

Event Timeline

mat added inline comments.
net/libzmq4/Makefile
8

The first should be ${DISTNAME}.tar.gz

The second should probably not be fetched manually like that but using the USE_GITHUB framework, and certainly not as a .zip file.

60

Please, add those files to the pkg-plist file.

65

remove empty line.

net/libzmq4/Makefile
8
  • [net/libzmq4] Updates by mat's suggestions #1
net/libzmq4/Makefile
6

Remove this and integrate it in GH_TAGNAME.

7–10

Move all this below GNU_CONFIGURE (line 26)

8

Remove this line.

11

Remove this.

60

Remove this.

  • [net/libzmq4] Updates by review suggestions #3

You should rerun make makesum, there are a couple of files that should not be there.