Page MenuHomeFreeBSD

tighten buffer bounds in imgact_binmisc_populate_interp
ClosedPublic

Authored by emaste on Mar 17 2017, 7:32 PM.
Tags
None
Referenced Files
F171546565: D10042.diff
Fri, Sep 11, 4:50 PM
Unknown Object (File)
Thu, Sep 10, 5:25 PM
Unknown Object (File)
Mon, Sep 7, 3:12 AM
Unknown Object (File)
Sat, Sep 5, 4:32 PM
Unknown Object (File)
Sat, Sep 5, 4:32 PM
Unknown Object (File)
Sat, Sep 5, 4:46 AM
Unknown Object (File)
Fri, Sep 4, 8:07 AM
Unknown Object (File)
Thu, Sep 3, 1:48 PM
Subscribers
None

Details

Summary

We must ensure there's space for the terminating null in the temporary buffer in imgact_binmisc_populate_interp().

Note that there is not a possible buffer overflow here, because xbe->xbe_interpreter's length and null termination is checked in imgact_binmisc_add_entry() before imgact_binmisc_populate_interp() is called, but the latter should correctly enforce its own bounds.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 21 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.