Page MenuHomeFreeBSD

tighten buffer bounds in imgact_binmisc_populate_interp
ClosedPublic

Authored by emaste on Mar 17 2017, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 11:58 PM
Unknown Object (File)
Fri, Oct 3, 10:32 AM
Unknown Object (File)
Tue, Sep 23, 11:06 PM
Unknown Object (File)
Thu, Sep 18, 6:36 PM
Unknown Object (File)
Aug 26 2025, 9:43 PM
Unknown Object (File)
Aug 16 2025, 1:02 AM
Unknown Object (File)
Aug 9 2025, 4:52 AM
Unknown Object (File)
Jul 24 2025, 4:33 PM
Subscribers
None

Details

Summary

We must ensure there's space for the terminating null in the temporary buffer in imgact_binmisc_populate_interp().

Note that there is not a possible buffer overflow here, because xbe->xbe_interpreter's length and null termination is checked in imgact_binmisc_add_entry() before imgact_binmisc_populate_interp() is called, but the latter should correctly enforce its own bounds.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 21 2017, 3:03 PM
This revision was automatically updated to reflect the committed changes.