Update pkg message for apache 2.4 users for Apache 2.4's new security model.
PR: 217850
Submitted By: dirkx@webweaving.org
Approved By: (adamw|rene) (Mentor)
Details
Details
poudriere
portlint
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Saying that you should add the AddHandler is a bad idea. It is not always true, many people use php through the fpm mechanism, this is why only the mod_php* ports tell you to add them.
www/joomla3/files/pkg-message.in | ||
---|---|---|
14 ↗ | (On Diff #26380) | IIRC, that's not quite right. apache24 doesn't just add that line, it needs to replace at least the Allow from all line (possibly the Order line too?). |
www/joomla3/files/pkg-message.in | ||
---|---|---|
14 ↗ | (On Diff #26380) | that's how I have it for my installation at https://joomla.lerctr.org/ so, I'm not inclined to change that. |
www/joomla3/files/pkg-message.in | ||
---|---|---|
14 ↗ | (On Diff #26380) | You have Allow from all Require all granted in your apache 2.4 setup? |
www/joomla3/files/pkg-message.in | ||
---|---|---|
14 ↗ | (On Diff #26380) | yes. <VirtualHost 192.147.25.65:443> ServerName joomla.lerctr.org DocumentRoot /usr/local/www/joomla3 ErrorLog "/var/log/httpd/joomla-ssl-error_log" CustomLog "/var/log/httpd/joomla-ssl-access_log" common <Location /> Order deny,allow allow from all require all granted </Location> |
Comment Actions
TIL!
Go for it, but with 3 changes:
- Capitalize the R in Required to fit the other lines.
- Improve your commit message. Right now it's confusing and doesn't really say what the commit is about. Really it's about showing Apache 2.4 users what to do, not about a changing security model.
- You need more fields than just PR. This change was submitted by someone who deserves credit, and it needs an Approved by: field.