o get rid of redundant --localstatedir
o get rid of deprecated ${PORTSDIR} in depends lines
o reduce number of pre/post targets
o get rid of root check for MKCHECK option:
building as non-root doesn't affect final package
o obey LOCALBASE in several new placesDetails
Details
- Reviewers
mat
poudriere testport - OK
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 8049 Build 8236: arc lint + arc unit
Event Timeline
Comment Actions
Before you commit this, you'll repeat 20 times:
LOCALBASE is where my dependencies are installer, PREFIX is where I install myself.
| security/samhain/Makefile | ||
|---|---|---|
| 164 | There is a good chance that this myconffile variable can be set directly with some --with-myconffile=${FOO} or something. Also, this line does *not* belong in the extract phase, but in the patch one. | |
Comment Actions
address mat's feedback
Unfortunately, --with-config-file is used both at install and at runtime
and we would like to install these with .sample suffix.