Page MenuHomeFreeBSD

cleanup security/samhain
Needs ReviewPublic

Authored by lifanov on Mar 14 2017, 4:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 12:53 AM
Unknown Object (File)
Mon, Oct 20, 3:15 PM
Unknown Object (File)
Mon, Oct 20, 3:15 PM
Unknown Object (File)
Mon, Oct 20, 1:30 AM
Unknown Object (File)
Sat, Oct 4, 1:11 AM
Unknown Object (File)
Sep 30 2025, 4:22 PM
Unknown Object (File)
Sep 27 2025, 9:10 PM
Unknown Object (File)
Sep 27 2025, 6:32 PM
Subscribers

Details

Reviewers
mat
Summary
o get rid of redundant --localstatedir
o get rid of deprecated ${PORTSDIR} in depends lines
o reduce number of pre/post targets
o get rid of root check for MKCHECK option:
   building as non-root doesn't affect final package
o obey LOCALBASE in several new places
Test Plan

poudriere testport - OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8102
Build 8306: arc lint + arc unit

Event Timeline

Before you commit this, you'll repeat 20 times:

LOCALBASE is where my dependencies are installer, PREFIX is where I install myself.

security/samhain/Makefile
164

There is a good chance that this myconffile variable can be set directly with some --with-myconffile=${FOO} or something.

Also, this line does *not* belong in the extract phase, but in the patch one.

address mat's feedback

Unfortunately, --with-config-file is used both at install and at runtime
and we would like to install these with .sample suffix.

It still should be in the patch phase.