Page MenuHomeFreeBSD
Feed Advanced Search

Wed, May 29

mhorne closed D45383: Adjust comments referencing vm_mem_init().
Wed, May 29, 5:36 PM

Mon, May 27

mhorne committed rGdeab57178f0b: Adjust comments referencing vm_mem_init() (authored by mhorne).
Adjust comments referencing vm_mem_init()
Mon, May 27, 9:39 PM
mhorne added inline comments to D45383: Adjust comments referencing vm_mem_init().
Mon, May 27, 4:19 PM
mhorne requested review of D45383: Adjust comments referencing vm_mem_init().
Mon, May 27, 4:18 PM
mhorne added inline comments to D45327: riscv: rework page table bootstrap.
Mon, May 27, 4:13 PM
mhorne added inline comments to D45328: riscv: smarter DMAP construction.
Mon, May 27, 3:17 PM
mhorne updated the test plan for D45328: riscv: smarter DMAP construction.
Mon, May 27, 3:15 PM
mhorne added inline comments to D45324: Construct an identity map in locore.S.
Mon, May 27, 2:50 PM
mhorne committed rG1b1c7e088c58: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Mon, May 27, 2:45 PM
mhorne committed rGbdfd8f68faaa: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Mon, May 27, 2:45 PM
mhorne committed rGed10a9398d05: riscv: fix L0 PTE setup (Sv48) (authored by mhorne).
riscv: fix L0 PTE setup (Sv48)
Mon, May 27, 2:45 PM

Fri, May 24

mhorne committed rGb5e17840de65: arm64, riscv: removed unused struct pv_addr (authored by mhorne).
arm64, riscv: removed unused struct pv_addr
Fri, May 24, 1:56 PM
mhorne committed rG1d3c23676de3: arm64, riscv: remove unused declaration (authored by mhorne).
arm64, riscv: remove unused declaration
Fri, May 24, 1:56 PM
mhorne closed D45323: arm64, riscv: remove unused declaration.
Fri, May 24, 1:56 PM
mhorne closed D45322: arm64, riscv: removed unused struct pv_addr.
Fri, May 24, 1:56 PM
mhorne abandoned D45321: pmap_is_valid_memattr: drop unused 'pmap' argument.
In D45321#1034234, @kib wrote:

Logically, it doesn't make sense that this result would differ per-pmap.

...

While there's currently no difference between pmap types in the handling of memattrs, it's not obvious to me that that'll always be true. In other words, I don't really agree with the premise of the patch. Maybe I'm missing some reason that my concern is invalid.

There is already a PAT mode (UC-) which cannot be represented in EPT. Although the mode is a hack to fix broken sofware (I believe), it is still a demonstration of the issue.

Fri, May 24, 1:33 PM

Thu, May 23

mhorne requested review of D45328: riscv: smarter DMAP construction.
Thu, May 23, 7:53 PM
mhorne requested review of D45327: riscv: rework page table bootstrap.
Thu, May 23, 7:53 PM
mhorne requested review of D45326: riscv: Don't handle missing kernel L3 pages.
Thu, May 23, 7:53 PM
mhorne requested review of D45325: riscv: adjust physmem reservation.
Thu, May 23, 7:53 PM
mhorne requested review of D45324: Construct an identity map in locore.S.
Thu, May 23, 7:52 PM
mhorne added a reviewer for D45321: pmap_is_valid_memattr: drop unused 'pmap' argument: kib.
Thu, May 23, 7:25 PM
mhorne requested review of D45323: arm64, riscv: remove unused declaration.
Thu, May 23, 7:17 PM
mhorne requested review of D45322: arm64, riscv: removed unused struct pv_addr.
Thu, May 23, 7:16 PM
mhorne requested review of D45321: pmap_is_valid_memattr: drop unused 'pmap' argument.
Thu, May 23, 7:16 PM
mhorne requested review of D45320: riscv: Move sigcode out of locore.S.
Thu, May 23, 7:15 PM
mhorne requested review of D45319: devmap: eliminate useless argument.
Thu, May 23, 7:15 PM
mhorne requested review of D45318: physmem: zero entire array.
Thu, May 23, 7:14 PM

Wed, May 22

mhorne accepted D45228: Implement atomic_load_acq_16.
Wed, May 22, 1:53 PM
mhorne accepted D45226: Fix SSTC extension support.
Wed, May 22, 1:48 PM

Fri, May 17

mhorne added inline comments to D45228: Implement atomic_load_acq_16.
Fri, May 17, 2:25 PM
mhorne accepted D45226: Fix SSTC extension support.
Fri, May 17, 2:19 PM

Thu, May 16

mhorne committed rG8930e7d8ea4d: save-entropy: Add manual page (authored by fernape).
save-entropy: Add manual page
Thu, May 16, 5:26 PM
mhorne added inline comments to D45213: vm: pair up conversion macros.
Thu, May 16, 1:51 PM
mhorne accepted D45170: libkern: add ilog2 helpers.

LGTM

Thu, May 16, 1:46 PM

Wed, May 15

mhorne committed rGd7adf3b47a05: riscv: fix L0 PTE setup (Sv48) (authored by mhorne).
riscv: fix L0 PTE setup (Sv48)
Wed, May 15, 5:10 PM
mhorne closed D45210: riscv: fix L0 PTE setup (Sv48).
Wed, May 15, 5:10 PM
mhorne requested review of D45210: riscv: fix L0 PTE setup (Sv48).
Wed, May 15, 3:49 PM
mhorne added inline comments to D45170: libkern: add ilog2 helpers.
Wed, May 15, 3:26 PM

Tue, May 14

mhorne accepted D45159: uart: Honour clock-frequency in FDT for UART_FDT_CLASS if present.

Thank you for finding the proper fix! Working fine on my end.

Tue, May 14, 2:53 PM

Thu, May 9

mhorne accepted D45085: vm: simplify conditional for dumping startup pages.
Thu, May 9, 5:07 PM

Tue, May 7

mhorne committed rG0612538e3ac9: jh7110: Add StarFive JH7110 clock/reset generator drivers (authored by jsihv_gmx.com).
jh7110: Add StarFive JH7110 clock/reset generator drivers
Tue, May 7, 4:09 PM
mhorne added a reverting change for rG5d6d6278979b: jh7110: Add StarFive JH7110 clock/reset generator drivers: rG6ea05fce8e2e: Revert "jh7110: Add StarFive JH7110 clock/reset generator drivers".
Tue, May 7, 4:08 PM
mhorne committed rG6ea05fce8e2e: Revert "jh7110: Add StarFive JH7110 clock/reset generator drivers" (authored by mhorne).
Revert "jh7110: Add StarFive JH7110 clock/reset generator drivers"
Tue, May 7, 4:08 PM
mhorne added a reverting change for D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver: rG6ea05fce8e2e: Revert "jh7110: Add StarFive JH7110 clock/reset generator drivers".
Tue, May 7, 4:08 PM
mhorne committed rGc8b472aa4b9d: jh7110: enable MMC driver (authored by mhorne).
jh7110: enable MMC driver
Tue, May 7, 4:05 PM
mhorne committed rG5d6d6278979b: jh7110: Add StarFive JH7110 clock/reset generator drivers (authored by mhorne).
jh7110: Add StarFive JH7110 clock/reset generator drivers
Tue, May 7, 4:05 PM
mhorne committed rGcf0876820717: starfive: add a syscon driver (authored by mhorne).
starfive: add a syscon driver
Tue, May 7, 4:05 PM
mhorne closed D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.
Tue, May 7, 4:05 PM
mhorne closed D44026: JH7110 MMC driver.
Tue, May 7, 4:05 PM
mhorne committed rG560406982489: busdma: deduplicate _bus_dmamap_addseg() function (authored by mhorne).
busdma: deduplicate _bus_dmamap_addseg() function
Tue, May 7, 4:05 PM
mhorne committed rGa77e1f0f81df: busdma: better handling of small segment bouncing (authored by mhorne).
busdma: better handling of small segment bouncing
Tue, May 7, 4:05 PM
mhorne closed D44270: starfive: add a syscon driver.
Tue, May 7, 4:04 PM
mhorne closed D45048: busdma: better handling of small segment bouncing.
Tue, May 7, 4:04 PM
mhorne closed D45047: busdma: deduplicate _bus_dmamap_addseg() function.
Tue, May 7, 4:04 PM

Mon, May 6

mhorne added a comment to D45085: vm: simplify conditional for dumping startup pages.

Thanks for this. Seems good to me, with one question inline.

Mon, May 6, 5:41 PM

Fri, May 3

mhorne committed rG227f81c8bd0f: save-entropy: Add manual page (authored by fernape).
save-entropy: Add manual page
Fri, May 3, 8:26 PM

May 1 2024

mhorne committed rG63b747823bea: hier.7: polish entry to system manual (authored by concussious.bugzilla_runbox.com).
hier.7: polish entry to system manual
May 1 2024, 6:48 PM
mhorne committed rG3d509058db55: hier.7: various improvements (authored by concussious.bugzilla_runbox.com).
hier.7: various improvements
May 1 2024, 6:48 PM
mhorne committed rGa7a687302375: BSD.usr.dist: remove empty /usr/libdata/gcc directory (authored by mhorne).
BSD.usr.dist: remove empty /usr/libdata/gcc directory
May 1 2024, 6:48 PM
mhorne committed rG1d921be5a889: ieee80211_vap(9): fix the title (authored by mhorne).
ieee80211_vap(9): fix the title
May 1 2024, 6:48 PM
mhorne added inline comments to D45044: uma: retire UMA_MD_SMALL_ALLOC.
May 1 2024, 5:03 PM
mhorne added inline comments to D45044: uma: retire UMA_MD_SMALL_ALLOC.
May 1 2024, 5:02 PM
mhorne updated the test plan for D45048: busdma: better handling of small segment bouncing.
May 1 2024, 4:37 PM
mhorne requested review of D45048: busdma: better handling of small segment bouncing.
May 1 2024, 4:34 PM
mhorne requested review of D45047: busdma: deduplicate _bus_dmamap_addseg() function.
May 1 2024, 4:33 PM

Apr 30 2024

mhorne accepted D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

LGTM. We will still have to wait until @manu has finished with the DTS upgrade to 6.10.

Apr 30 2024, 3:27 PM

Apr 23 2024

mhorne committed rGc5989febcc00: ieee80211_vap(9): fix the title (authored by mhorne).
ieee80211_vap(9): fix the title
Apr 23 2024, 4:01 PM
mhorne committed rG96a2e036b709: Update manual page references and macros to align to mandoc syntax (authored by christopher.davidson_gmail.com).
Update manual page references and macros to align to mandoc syntax
Apr 23 2024, 3:53 PM
mhorne accepted D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

I am happy with this. There are a couple whitespace/style issues remaining, but I will do a pass to fix them before committing. Thanks for your work, I will aim to merge by the end of the week!

Apr 23 2024, 3:32 PM

Apr 18 2024

mhorne committed rGd16abff36292: bhnd_erom.9: remove self-reference (authored by christopher.davidson_gmail.com).
bhnd_erom.9: remove self-reference
Apr 18 2024, 6:21 PM
mhorne committed rGde436a4fbf79: device_add_child.9: remove self-reference (authored by christopher.davidson_gmail.com).
device_add_child.9: remove self-reference
Apr 18 2024, 6:21 PM
mhorne committed rGac3bd5959b82: cfumass.4: remove self-reference (authored by christopher.davidson_gmail.com).
cfumass.4: remove self-reference
Apr 18 2024, 6:21 PM
mhorne committed rG7f1fc5dbc694: mount_mfs.8: remove self-reference (authored by christopher.davidson_gmail.com).
mount_mfs.8: remove self-reference
Apr 18 2024, 6:21 PM
mhorne committed rGac4ddd8b1f67: open.2: remove self-reference (authored by christopher.davidson_gmail.com).
open.2: remove self-reference
Apr 18 2024, 6:21 PM
mhorne committed rGc8aac78681e5: assert.3: Update manual page based on mandoc -Tlint (authored by christopher.davidson_gmail.com).
assert.3: Update manual page based on mandoc -Tlint
Apr 18 2024, 6:21 PM
mhorne committed rG0c62a06b84ab: kassert.h: update MPASS definition commentary (authored by mhorne).
kassert.h: update MPASS definition commentary
Apr 18 2024, 6:20 PM
mhorne committed rGe9d06e89ce63: KASSERT(9): describe history of MPASS (authored by mhorne).
KASSERT(9): describe history of MPASS
Apr 18 2024, 6:20 PM
mhorne committed rG929d8ef0f71e: KASSERT(9): add assertion message guidelines (authored by mhorne).
KASSERT(9): add assertion message guidelines
Apr 18 2024, 6:20 PM
mhorne committed rG74b1a9ccf9a7: cp: Remove useless ssize_t cast (authored by collin.funk1_gmail.com).
cp: Remove useless ssize_t cast
Apr 18 2024, 6:20 PM
mhorne committed rG5f375fdbdfdb: em.4: add interfaces to name section (authored by concussious.bugzilla_runbox.com).
em.4: add interfaces to name section
Apr 18 2024, 6:19 PM
mhorne committed rG9050a43e8e2c: intro.9: minor changes (authored by grahamperrin).
intro.9: minor changes
Apr 18 2024, 6:13 PM
mhorne committed rG4e997a32db3d: riscv: Introduce support for APLIC interrupt controller (authored by himanshu_thechauhan.dev).
riscv: Introduce support for APLIC interrupt controller
Apr 18 2024, 6:13 PM
mhorne committed rG9319a8a11a6f: simple_mfd: don't attach children twice (authored by mhorne).
simple_mfd: don't attach children twice
Apr 18 2024, 6:13 PM
mhorne committed rG29701960b3ba: clk_fixed: call clkdom_dump() for verbose boot (authored by mhorne).
clk_fixed: call clkdom_dump() for verbose boot
Apr 18 2024, 6:13 PM
mhorne committed rG5eb27a0d68f5: clk_fixed: quiet by default (authored by mhorne).
clk_fixed: quiet by default
Apr 18 2024, 6:13 PM
mhorne committed rG327987597bff: clkdom_dump(): improve output text (authored by mhorne).
clkdom_dump(): improve output text
Apr 18 2024, 6:13 PM
mhorne committed rG0a40193a6e0f: busdma: fix page miscount for small segment sizes (authored by mhorne).
busdma: fix page miscount for small segment sizes
Apr 18 2024, 6:12 PM
mhorne committed rG9dfe484e126d: hier.7: polish entry to system manual (authored by concussious.bugzilla_runbox.com).
hier.7: polish entry to system manual
Apr 18 2024, 6:00 PM
mhorne committed rGf115e03a47b9: intro(7): add link to new networking(7) (authored by mhorne).
intro(7): add link to new networking(7)
Apr 18 2024, 6:00 PM

Apr 17 2024

mhorne updated the diff for D44026: JH7110 MMC driver.

Add check for generic compatible string exported by current u-boot.

Apr 17 2024, 5:33 PM
mhorne commandeered D44026: JH7110 MMC driver.

Taking this over so I can publish some additions/changes...

Apr 17 2024, 5:32 PM
mhorne added a comment to D43037: jh7110_clkgen: Add StarFive JH7110 clock generator driver.

Overall this is looking good to me. The core clock logic seems right, as well as the SYS group. I did not verify the clock hierarchy in detail compared to the TRM.

Apr 17 2024, 3:04 PM

Apr 3 2024

mhorne committed rG81727a3dd382: bhnd_erom.9: remove self-reference (authored by christopher.davidson_gmail.com).
bhnd_erom.9: remove self-reference
Apr 3 2024, 5:05 PM
mhorne committed rGf9ea7b6e8253: device_add_child.9: remove self-reference (authored by christopher.davidson_gmail.com).
device_add_child.9: remove self-reference
Apr 3 2024, 5:05 PM
mhorne committed rGf8ce29b63181: cfumass.4: remove self-reference (authored by christopher.davidson_gmail.com).
cfumass.4: remove self-reference
Apr 3 2024, 5:05 PM
mhorne committed rG2ebc7806a1e4: mount_mfs.8: remove self-reference (authored by christopher.davidson_gmail.com).
mount_mfs.8: remove self-reference
Apr 3 2024, 5:05 PM
mhorne committed rGd3de1bd429bc: open.2: remove self-reference (authored by christopher.davidson_gmail.com).
open.2: remove self-reference
Apr 3 2024, 5:05 PM

Mar 22 2024

mhorne committed rGdc7ae2bc6fad: kern_ctf.c: fix linking with nooptions DDB (authored by mhorne).
kern_ctf.c: fix linking with nooptions DDB
Mar 22 2024, 4:31 PM

Mar 21 2024

mhorne committed rG3f72f36cf2f9: assert.3: Update manual page based on mandoc -Tlint (authored by christopher.davidson_gmail.com).
assert.3: Update manual page based on mandoc -Tlint
Mar 21 2024, 6:25 PM