net80211: allow a single wlan crypto module to register for >1 cipher

[adrian]

Summary

This allows a single wlan crypto module to register for more than
one cipher. Without it, duplicate linkerset structs are initialised
for the actual module loading machinery itself.

I've tested this in my private tree with wlan_ccmp providing both
128 and 256 bit cipher support.

[adrian]

url update

[adrian]

url update

[cc]

I don't get it why this change made a difference in your test. Is it because of the bug I pointed in TEXT_SET ?

sys/net80211/ieee80211_freebsd.h

420

I think version is not needed here in this macro.

429

Can we remove the double hash operators ## here inside the "crypto##_set" of macro TEXT_SET? It's confusing to me until I checked other examples in this file.

for example:

TEXT_SET(scanner_set, name##_modevent);
TEXT_SET(acl_set, alg##_modevent);
...

[adrian]

address comments

[adrian]

sys/net80211/ieee80211_freebsd.h

429

I think there's a reason for it to be done like this, same as ratectl?

Let's figure that out after this stuff lands, as a separate clean-up path.

[cc]

If you have a plan to figure out TEXT_SET(crypto##_set, name##_modevent) and TEXT_SET(ratectl##_set, alg##_modevent), I have no problem with this patch.

[cc]

sys/net80211/ieee80211_freebsd.h

420

Now I got it why you rename this macro and use it in D44921.

[bz]

Would be great if the commit message would mention IEEE80211_CRYPTO_MODULE() somehow so one can find this in the future more easily.

Also the Phab template has a separate section to describe the testing.