Differential D44936

wlan: update drivers to use ieee80211_set_hardware_ciphers()
Needs ReviewPublic
Actions

Authored by adrian on Thu, Apr 25, 4:08 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, May 1, 5:07 PM

	Unknown Object (File)
	Tue, Apr 30, 8:15 PM

	Unknown Object (File)
	Sat, Apr 27, 5:43 PM

	Unknown Object (File)
	Fri, Apr 26, 5:20 PM

	Unknown Object (File)
	Fri, Apr 26, 2:06 PM

	Unknown Object (File)
	Fri, Apr 26, 2:06 PM

	Unknown Object (File)
	Fri, Apr 26, 12:13 PM

	Unknown Object (File)
	Fri, Apr 26, 8:26 AM

Subscribers

Details

Reviewers

None

Group Reviewers

Summary

This migrates drivers to use ieee80211_set_hardware_ciphers() instead
of setting ic_cryptocaps directly.

The only driver that hasn't entirely had ic_cryptocaps access removed
is if_ath(4); it's doing something tricksy to work around a hardware
issue (it looks like TKIP + WME/QoS frames may be buggy or not
supported.) I'll need to think about this and address it in a future
commit.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57341
Build 54229: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Apr 25, 4:08 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Apr 25, 4:08 AM

adrian requested review of this revision.Thu, Apr 25, 4:08 AM

Harbormaster completed remote builds in B57340: Diff 137641.Thu, Apr 25, 4:08 AM

update w/ diff url

Harbormaster completed remote builds in B57341: Diff 137642.Thu, Apr 25, 4:09 AM

adrian added a parent revision: D44922: wpa: add cipher flag support for the new ciphers.Thu, Apr 25, 4:09 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian mentioned this in D44827: net80211: add driver / crypto methods to set the hardware / software cipher suites.Thu, Apr 25, 4:17 AM

adrian added a child revision: D44937: wlan: add some calls to ieee80211_set_driver_keymgmt_suites().Thu, Apr 25, 4:45 AM

Looks reasonable to me

Revision Contents
Changeset List

Path

Size

sys/

dev/

ath/

26 lines

iwn/

3 lines

mwl/

9 lines

rtwn/

11 lines

usb/

wlan/

6 lines

8 lines

8 lines

wpi/

3 lines

Diff 137642

sys/dev/ath/if_ath.c

Loading...

sys/dev/iwn/if_iwn.c

Loading...

sys/dev/mwl/if_mwl.c

Loading...

sys/dev/rtwn/if_rtwn.c

Loading...

sys/dev/usb/wlan/if_rsu.c

Loading...

sys/dev/usb/wlan/if_rum.c

Loading...

sys/dev/usb/wlan/if_run.c

Loading...

sys/dev/wpi/if_wpi.c

Loading...