Page MenuHomeFreeBSD

heimdal: Add 64-bit integer support to ASN.1 compiler, part 1
AcceptedPublic

Authored by dim on Tue, Apr 16, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 7:57 PM
Unknown Object (File)
Fri, Apr 26, 5:15 AM
Unknown Object (File)
Thu, Apr 18, 4:50 PM
Unknown Object (File)
Wed, Apr 17, 5:08 PM
Unknown Object (File)
Wed, Apr 17, 1:55 AM
Subscribers

Details

Reviewers
emaste
cy
Summary

Import upstream 19d378f44:

ASN.1 INTEGERs will now compile to C int64_t or uint64_t, depending
on whether the constraint ranges include numbers that cannot be
represented in 32-bit ints and whether they include negative
numbers.

Template backend support included.  check-template is now built with
--template, so we know we're testing it.

Tests included.

This is a direct application of the upstream patch, but it DOES NOT compile.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dim requested review of this revision.Tue, Apr 16, 7:13 PM

There is no need to touch Makefile.am. We don't use it.

crypto/heimdal/lib/asn1/test.asn1
11

We don't use test.asn1.

crypto/heimdal/lib/asn1/test.asn1
11

IMO it makes sense to just apply the upstream patch though, there's not much value in going out of our way to undo part of it.

Except for the files we don't use, LGTM.

This revision is now accepted and ready to land.Wed, Apr 17, 3:21 AM