heimdal: Add 64-bit integer support to ASN.1 compiler, part 2
ClosedPublic
Actions

Authored by dim on Tue, Apr 16, 7:13 PM.

Details

Reviewers

emaste
cy

Commits

rG2efe30782cd9: heimdal: Add 64-bit integer support to ASN.1 compiler
rG164f125311a6: heimdal: Add 64-bit integer support to ASN.1 compiler
rG1b7487592987: heimdal: Add 64-bit integer support to ASN.1 compiler

Summary

heimdal: Add 64-bit integer support to ASN.1 compiler, part 2

This adjusts the generated files:

asn1parse.c, asn1parse.h (although these seem to be generated by the FreeBSD build system too)
der-protos.h, which needs a bunch of new prototypes. I stole them from a der-protos.h generated by the upstream build system, which uses a perl script for this.
adjust printf format strings for int64_t. Upstream uses %lld for this, but that is not portable, and leads to lots of -Werror warnings.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim created this revision.Tue, Apr 16, 7:13 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 16, 7:13 PM

dim requested review of this revision.Tue, Apr 16, 7:13 PM

dim retitled this revision from heimdal: Add 64-bit integer support to ASN.1 compiler, part 1 to heimdal: Add 64-bit integer support to ASN.1 compiler, part 2.

dim edited the summary of this revision. (Show Details)

emaste added a parent revision: D44815: heimdal: Add 64-bit integer support to ASN.1 compiler, part 1.Tue, Apr 16, 7:16 PM

emaste mentioned this in D44812: heimdal: Add 64-bit integer support to ASN.1 compiler.Wed, Apr 17, 1:22 AM

cy accepted this revision.Wed, Apr 17, 3:22 AM

This revision is now accepted and ready to land.Wed, Apr 17, 3:22 AM

Closed by commit rG1b7487592987: heimdal: Add 64-bit integer support to ASN.1 compiler (authored by dim). · Explain WhyWed, Apr 17, 5:00 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rG1b7487592987: heimdal: Add 64-bit integer support to ASN.1 compiler.

dim added a commit: rG164f125311a6: heimdal: Add 64-bit integer support to ASN.1 compiler.Wed, Apr 24, 9:28 PM

dim added a commit: rG2efe30782cd9: heimdal: Add 64-bit integer support to ASN.1 compiler.