HomeFreeBSD

Temporarily lock Giant while we update td_ucred. The proc lock doesn't
rS91405Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

Temporarily lock Giant while we update td_ucred. The proc lock doesn't
fully protect p_ucred yet so Giant is needed until all the p_ucred
locking is done. This is the original reason td_ucred was not used
immediately after its addition. Unfortunately, not using td_ucred is
not enough to avoid problems. Since p_ucred could be stale, we could
actually be dereferencing a stale pointer to dink with the refcount, so
we really need Giant to avoid foot-shooting. This allows td_ucred to
be safely used as well.

Details

Provenance
jhbAuthored on
Parents
rS91404: Put the last added source file in proper order.
Branches
Unknown
Tags
Unknown

Event Timeline