HomeFreeBSD

Remove unnecessary WITNESS check in x86 bus_dma

Description

Remove unnecessary WITNESS check in x86 bus_dma

When I did some bus_dma cleanup in r320528, I brought forward some sketchy
WITNESS checks from the prior x86 busdma wrappers, instead of recognizing
them as technical debt and just dropping them. Two of these were removed in
r346351 and r346851, but one remains in bounce_bus_dmamem_alloc(). This check
could be constrained to only apply in the BUS_DMA_NOWAIT case, but it's cleaner
to simply remove it and rely on the checks already present in the sleepable
allocation paths used by this function.

While here, remove another unnecessary witness check in bus_dma_tag_create
(the tag is always allocated with M_NOWAIT), and fix a couple of typos.

Reported by: cem
Reviewed by: kib, cem
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D25107

Details

Committed
jahJun 3 2020, 12:16 AM
Reviewer
kib
Differential Revision
D25107: Remove unnecessary WITNESS check in x86 bounce_bus_dmamem_alloc()
Parents
rS361740: lld: Set DF_1_PIE for -pie
Branches
Unknown
Tags
Unknown