HomeFreeBSD

MFC r358427: initialize oifp to avoid bogus results/panics in edge cases

Description

MFC r358427: initialize oifp to avoid bogus results/panics in edge cases

In certain cases (probably not during normal operation but observed in
the lab during development) ip6_ouput() could return without error
and ifpp (&oifp) not updated.
Given oifp was never initialized we would take the later branch
as oifp was not NULL, and when calling icmp6_ifstat_inc() we would
panic dereferencing a garbage pointer.
For code stability initialize oifp to NULL before first use to always
have a deterministic value and not rely on a called function to behave
and always and for ever do the work for us as we hope for.

Sponsored by: Netflix

Details

Provenance
bzAuthored on
Parents
rS358542: MFC r358427: initialize oifp to avoid bogus results/panics in edge cases
Branches
Unknown
Tags
Unknown