Diffusion FreeBSD src repository - subversion rS355311

Don't run sched_preempt() inside of an extra critical section. This disables
rS355311
Actions

Description

Don't run sched_preempt() inside of an extra critical section. This disables
the sched_preempt() switch optimization and causes the sched lock to be dropped
and immediately reacquired.

Reviewed by: jhb, kib, mav, markj (with changes)
Differential Revision: https://reviews.freebsd.org/D22623

Details

Provenance

jeff	Authored on

Reviewer

jhb

Differential Revision

D22623: Running the sched_preempt handler in a critical section causes us to acquire the scheduler lock twice in a row. It is not necessary since interrupts aredisabled already in this path.

Parents

rS355310: I took over mentorship of Scott Philips a while ago, update the mentors

Branches

Unknown

Tags

Unknown

Event Timeline

jeff committed rS355311: Don't run sched_preempt() inside of an extra critical section. This disables.Dec 2 2019, 10:34 PM

jeff added an edge: D22623: Running the sched_preempt handler in a critical section causes us to acquire the scheduler lock twice in a row. It is not necessary since interrupts aredisabled already in this path..

Changes (1)

Path

Size

head/

sys/

x86/

mp_x86.c

rS355311

View Options