HomeFreeBSD

Refactor, removing one compare.

Description

Refactor, removing one compare.

This changes the return code however the caller only tests for 0 and != 0.
One might ask then, why multiple return codes when the caller only tests
for 0 and != 0? From what I can tell, Darren probably passed various
return codes for sake of debugging. The debugging code is long gone
however we can still use the different return codes using DTrace FBT
traces. We can still determine why the compare failed by examining the
differences between the fr1 and fr2 frentry structs, which is a simple
test in DTrace. This allows reducing the number of tests, improving the
code while not affecting our ability to capture information for
diagnostic purposes.

MFC after: 1 week

Details

Committed
cyJul 16 2019, 7:00 PM
Parents
rS350062: MFC r345632 by lwhsu: Fix `make` in sys/modules
Branches
Unknown
Tags
Unknown