HomeFreeBSD

sort(1): randomcoll: Skip the memory allocation entirely

Description

sort(1): randomcoll: Skip the memory allocation entirely

There's no reason to order based on strcmp of ASCII digests instead of
memcmp of the raw digests.

While here, remove collision fallback. If you collide two MD5s, they're
probably the same string anyway. If robustness against MD5 collisions is
desired, maybe we shouldn't use MD5.

None of the behavior of sort -R is specified by POSIX, so we're free to
implement this however we like. E.g., using a 128-bit counter and block cipher
to generate unique indices for each line of input.

PR: 230792 (2/many)
Relnotes: This will change the sort order for a given dataset with a

		given seed.  Other similarly breaking changes are planned.

Sponsored by: Dell EMC Isilon

Details

Committed
cemApr 4 2019, 11:32 PM
Parents
rS345895: Revert r320698, since the related userland changes were reverted by r338192.
Branches
Unknown
Tags
Unknown