Diffusion FreeBSD src repository - subversion rS337929

Fix Coverity warnings about mkstemp in tests
rS337929
Actions

Description

Fix Coverity warnings about mkstemp in tests

umask(2) should always be used prior to mkstemp(3) so the temporary file
won't be created with insecure permissions.

Reported by: Coverity
CID: 1331605 1347173 1375366 1339800 1331604 1296056 1296060
CID: 1296057 1296062
MFC after: 2 weeks

Details

Provenance

asomers

Authored on

Parents

rS337928: Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c

Branches

Unknown

Tags

Unknown

Event Timeline

asomers committed rS337929: Fix Coverity warnings about mkstemp in tests.Aug 16 2018, 9:36 PM

Changes (9)

Path

Size

head/

tests/

sys/

aio/

file/

kern/

pipe/

pipe_overcommit2_test.c

ptrace_test.c

unix_passfd_test.c

posixshm/

posixshm_test.c

rS337929

View Options

head/tests/sys/aio/aio_kqueue_test.c

View Options

head/tests/sys/aio/lio_kqueue_test.c

View Options

head/tests/sys/file/dup_test.c

View Options

head/tests/sys/file/flock_helper.c

View Options

head/tests/sys/kern/kern_copyin.c

View Options

head/tests/sys/kern/pipe/pipe_overcommit2_test.c

View Options

head/tests/sys/kern/ptrace_test.c

View Options

head/tests/sys/kern/unix_passfd_test.c

View Options

head/tests/sys/posixshm/posixshm_test.c

Fix Coverity warnings about mkstemp in testsrS337929Actions

Description

Details

Event Timeline

Changes (9)

rS337929

head/tests/sys/aio/aio_kqueue_test.c

head/tests/sys/aio/lio_kqueue_test.c

head/tests/sys/file/dup_test.c

head/tests/sys/file/flock_helper.c

head/tests/sys/kern/kern_copyin.c

head/tests/sys/kern/pipe/pipe_overcommit2_test.c

head/tests/sys/kern/ptrace_test.c

head/tests/sys/kern/unix_passfd_test.c

head/tests/sys/posixshm/posixshm_test.c

Fix Coverity warnings about mkstemp in tests
rS337929
Actions