HomeFreeBSD

bhnd(4)/bwn(4): Fix a number of small issues reported by Coverity.

Description

bhnd(4)/bwn(4): Fix a number of small issues reported by Coverity.

  • Fix reference of uninitialized error value in bhndb_generic_resume() if the dynamic window count is 0.
  • Fix incorrect bhnd_pmu(4) UPTME_MASK and PLL0_PC2_WILD_INT_MASK constants.
  • Variable definitions referenced by our generated SPROM layouts will never be NULL, but add explicit asserts to make that clear.
  • Add missing variable initialization in bhnd_nvram_sprom_ident().
  • Fix leak of driver array in bhnd_erom_probe_driver_classes().
  • Fix zero-length memset() in bhndb_pci_eio_init().
  • Fix an off-by-one error and potential invalid OOBSEL bit shift operation in bcma_dinfo_init_intrs().
  • Remove dead code in siba_suspend_hw().
  • Fix duplicate call to bhnd_pmu_enable_regulator() in both the enable and disable code paths of bhnd_compat_cc_pmu_set_ldoparef().

Reported by: Coverity
CIDs: 1355194, 1362020, 1362022, 1373114, 1366563, 1373115,

		1381569, 1381579, 1383555, 1383566, 1383571

Sponsored by: The FreeBSD Foundation

Details

Provenance
landonfAuthored on
Parents
rS326870: Handle the Facility Unavailable exception as a SIGILL
Branches
Unknown
Tags
Unknown