HomeFreeBSD

MFC r325947:

Description

MFC r325947:

Fix potential NULL pointer dereference of device physical path

In scsi_dev_advinfo(), if the physical path is being stored and there is a
malloc failure (malloc(9) is called with M_NOWAIT), we could wind up in a
situation where the device's physpath_len is set to the length the user
provided, but the physpath itself is NULL.

If another context then comes in to fetch the physical path value, we would
wind up trying to memcpy a NULL pointer into the caller's buffer.

So, set the physpath_len to 0 when we free the physpath on entry into the
store case for the physical path. Reset the length to a non-zero value only
after we've successfully malloced a buffer to hold it.

Submitted by: ken
Reviewed by: asomers
Sponsored by: Spectra Logic Corp

Details

Provenance
asomersAuthored on
Reviewer
asomers
Parents
rS326679: MFC r325946:
Branches
Unknown
Tags
Unknown