HomeFreeBSD

bhyve: avoid applying capsicum capabilities to file that was not opened

Description

bhyve: avoid applying capsicum capabilities to file that was not opened

When using -l option targeting file that can't be opened (ie. nmdm module
is not loaded and /dev/nmdm* is specified) bhyve tries to apply capsicum
capabilities to a file that was not opened.

Enclose that code in an if statement and only run it on correctly opened
descriptor also providing meaningful message in case of an error.

Submitted by: Pawel Biernacki <pawel.biernacki@gmail.com>
Reviewed by: grehan, emaste
Sponsoied by: Mysterious Code Ltd.
Differential Revision: D12985

Details

Committed
robakNov 11 2017, 10:50 PM
Reviewer
grehan
Differential Revision
D12985: bhyve: don't try to capsicumise after failed open
Parents
rS325726: Avoid locking and refing in sysctl_kern_proc_args if possible.
Branches
Unknown
Tags
Unknown