HomeFreeBSD

MFC r289739,r289743,r289897,r289901:

Description

MFC r289739,r289743,r289897,r289901:

r289739:

Correctly reintroduce the rudimentary smoke tests I botched up
in r289684

Sponsored by: EMC / Isilon Storage Division

r289743:

Revise "create_test_inputs" to simplify the file structure as
these testcases don't need to be nested as much as bin/ls/ls_tests.sh
do when verifying ls -a, ls -A, etc. This allows the tests to make
all paths relative to the top of the temporary directory instead of
always tacking on $ATF_TMPDIR, thus complicating things unnecessarily

Create non-empty files in create_test_inputs as well now, similar to
create_test_inputs2 in bin/ls/ls_tests.sh

Compare the input files to the output file contents using diff where
possible:

  • Skip over the fifo comparison for now because it always fails
  • Skip over the symlink comparison on cd9660 because it always fails today

Sponsored by: EMC / Isilon Storage Division

r289897:

Add more cd9660/FFS makefs testcases

General changes:

  • Parameterize out the mount command.
  • Use mtree to verify the contents of an image (check_image_contents) instead of using diff (diff verifies content, but not file metadata).
  • Move common logic out to functions (common_cleanup, mount_image, check_image_contents)
  • Add stub testcases for makefs -D (crashes with SIGBUS, similar to bug # 192839)
  • Add a note about the ISO-9660 and rockridge specs
  • Add testcases that exercise:
    • Creating disk images from an mtree and multiple directories.
    • -F flag use (not really an extensive testcase right now)

cd9660-specific test changes:

  • Remove an XXX comment about symlinks; I forgot that non-rockridge images turn symlinks into hardlinks.
  • Add testcases that exercise:
    • -o allow-deep-trees
    • -o allow-max-name stub testcase (doesn't seem to be implemented in makefs)
    • -o preparer (existence in image; not conformance to spec)
    • -o publisher (existence in image; not conformance to spec)
    • -o rockridge (basic)

Sponsored by: EMC / Isilon Storage Division

r289901:

Remove an ls -l I was using for debugging

Sponsored by: EMC / Isilon Storage Division

Details

Provenance
ngieAuthored on
Parents
rS290585: MFC r289441:
Branches
Unknown
Tags
Unknown