• Address review (and add a bit myself).
  • Tweek man page.
  • Remove all mention of RANDOM_FORTUNA. If the system owner wants YARROW or DUMMY, they ask for it, otherwise they get FORTUNA.
  • Tidy up headers a bit.
  • Tidy up declarations a bit.
  • Make static in a couple of places where needed.
  • Move Yarrow/Fortuna SYSINIT/SYSUNINIT to randomdev.c, moving us towards a single file where the algorithm context is used.
  • Get rid of random_*_process_buffer() functions. They were only used in one place each, and are better subsumed into those places.
  • Remove *_post_read() functions as they are stubs everywhere.
  • Assert against buffer size illegalities.
  • Clean up some silly code in the randomdev_read() routine.
  • Make the harvesting more consistent.
  • Make some requested argument name changes.
  • Tidy up and clarify a few comments.
  • Make some requested comment changes.
  • Make some requested macro changes.

• NOTE: the thing calling itself a 'unit test' is not yet a proper unit test, but it helps me ensure things work. It may be a proper unit test at some time in the future, but for now please don't make any assumptions or hold any expectations.

Differential Revision: https://reviews.freebsd.org/D2025
Approved by: so (/dev/random blanket)