HomeFreeBSD

Do not check if found IPv4 rte is dynamic if net.inet.icmp.drop_redirect is
rS241406Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

Do not check if found IPv4 rte is dynamic if net.inet.icmp.drop_redirect is
enabled. This eliminates one mtx_lock() per each routing lookup thus improving
performance in several cases (routing to directly connected interface or routing
to default gateway).

Icmp redirects should not be used to provide routing direction nowadays, even
for end hosts. Routers should not use them too (and this is explicitly restricted
in IPv6, see RFC 4861, clause 8.2).

Current commit changes rnh_machaddr function to 'stock' rn_match (and back) for every
AF_INET routing table in given VNET instance on drop_redirect sysctl change.

This change is part of bigger patch eliminating rte locking.

Sponsored by: Yandex LLC
MFC after: 2 weeks

Details

Provenance
melifaroAuthored on
Parents
rS241405: Really handle xpt_compile_path() error in xpt_bus_register() instead of
Branches
Unknown
Tags
Unknown

Event Timeline