HomeFreeBSD

if_arge has had a strange bug that only appears during high traffic
rS220357Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

if_arge has had a strange bug that only appears during high traffic
levels. TX would hang, RX wouldn't. A bit of digging showed the interface
send queue was full, but IFF_DRV_OACTIVE was clear and the hardware TX
queue was empty.

It turns out that there wasn't a check to drain the interface send
queue once hardware TX had completed, so if the interface send queue
had filled up in the meantime, subsequent packets would be dropped
by the higher layers and if_start (and thus arge_start()) would never
be called.

The fix is simple - call arge_start_locked() in the software interrupt
handler after the hardware TX queue has been handled or a TX underrun
occured. This way the interface send queue gets drained.

Details

Provenance
adrianAuthored on
Parents
rS220356: * Add some more debugging to if_arge
Branches
Unknown
Tags
Unknown

Event Timeline