HomeFreeBSD

In ppsintr, we needed ppsdev to get to the softc and nothing else.
rS145075Unpublished

Unpublished Commit ยท Learn More

No further details are available.

Description

In ppsintr, we needed ppsdev to get to the softc and nothing else.
Save a memory dereference in the ISR by passing this in directly.
Calling pps_capture is MP safe for all other operations on struct
pps_state, so there's no need to aquire the lock before we do this,
even from a fast ISR. Avoid dereferencing sc->ppbus until after
pps_capture is called as well. These actions reduce somewhat the
cache effects that cause variance in interrupt times. On an
especially slow test machine (300MHz Cyrix GXm), this reduces the
interrupt latency about about 10% (from 21us to 19us) and helps a
little with the variance (although most of the variance seems to be
caused by lots of interrupt masking).

This also happens fixes one or two of bde's style issues.

Details

Provenance
impAuthored on
Parents
rS145074: No reason to write \a and \v as octal escape sequences.
Branches
Unknown
Tags
Unknown

Event Timeline