java/wildfly80: New port: WildFly - replacement for JBoss Application Server
PR: ports/188339
Submitted by: Alexander Yerenkow <yerenkow@gmail.com>
Approved by: jadawin (mentor)
Description
Description
Details
Details
- Auditors
bapt - Provenance
pi Authored on - Parents
- rP355470: Fix build with new lua
- Branches
- Unknown
- Tags
Event Timeline
Comment Actions
All the @dirrmtry should imho also be @dirrm (at least most of them) make makeplist do create only dirrmtry it is up to the maintainer to make sure what is the right one
| /head/java/wildfly80/Makefile | ||
|---|---|---|
| 20 | I'm pretty sure this is not needed and can be worked around, committers should make sure to only use NEED_ROOT when there is no way to make it without it. | |
| 43 | This is not needed with stage, this is automatic | |
Comment Actions
About the @dirrmtry: The submitter said that it's not very easy to seperate out which directories will have modifications by the app while running, so
some might have left files over that will not allow the @dirrm.
I hoped to get him to seperate programs and data, but he said,
it's not possible right now. Apparently this is common in the
java world 8-(
| /head/java/wildfly80/Makefile | ||
|---|---|---|
| 20 | The submitter wanted to have all directories/files to be owned by user www/group www (because the running app writes into some directories using the www/www user/group. I have not found a way to achieve it without the NEED_ROOT, after digging in /usr/ports/Mk/bsd.port.mk. If I do not use NEED_ROOT, line 5579ff of /usr/ports/Mk/bsd.port.mk @owner root in front of the temp plist file. If there is another way to achieve it, I can try this, but I have not found any. | |
| 43 | I can provide a patch that changes it. Should I or should I tell the submitter to change it ? What's the right way to do it ? | |
Comment Actions
Concerning the dirrmtry, I understand you can safely ignore my comment on it :)
Concerning the user @owner www and @group www should do it
On the other hand it doesn't make much sense to have everything owned by the user www rather than just the directories where www should be able to write to.
You can just provide a patch through the usual mentor channel that fixes what can be fixed and show it the maintainer as a heads up
Comment Actions
Pi, culot, bapt,
I suggest we try this channel for approval, instead of your implicit. It will be a good try for us, I think.