HomeFreeBSD

libnv: Fix array unpack endianness logic

Description

libnv: Fix array unpack endianness logic

When a nvlist(9) is converted into a binary buffer by nvlist_pack(9),
the host endianness is encoded in the nvlist_header of the binary
buffer. The nvlist_unpack(9) function converts a given binary buffer
to an nvlist. In the conversion process the endianness encoded in the
nvlist_header is evaluated and -- should the encoded endianness differ
from the endianess of the decoding host -- endianness conversion is
applied to nvlist_header and nvpair_header elements as well as
to some nvpair values.

In 2015 @oshogbo extended libnv with array support (in 347a39b).
The unpacking code misses the possible need to convert the endianness
of the nvph_nitems element of nvpair_headers.

The patch (re)enables libnv to unpack nvlists regardless of the
endianness of the packing host.

Pull Request: https://github.com/freebsd/freebsd-src/pull/528

Details

Provenance
sg2342_googlemail.comAuthored on Aug 18 2021, 4:26 PM
oshogboCommitted on Sep 13 2021, 7:21 PM
Parents
rG93d6fa53c995: Disable -Woverflow errors for i386 for GCC 9.
Branches
Unknown
Tags
Unknown