HomeFreeBSD

usb: Don't call usb_msc_auto_quirk for UQ_MSC_IGNORE devices

Description

usb: Don't call usb_msc_auto_quirk for UQ_MSC_IGNORE devices

usb_msc_auto_quirk() potentially crashes usb devices with a hidden
storage (see bug 287333). These devices may still operate normally if
usb_msc_auto_quirk() would not be called all and the hidden storage is
ignored. This patch makes sure, that usb_msc_auto_quirk() is not called
when the UQ_MSC_IGNORE quirk is set for a device. It shouldn't be called
anyway if the hidden storage supposed to be ignored. This gives users a
chance to get their devices working by using

'usbconfig add_dev_quirk_vplh <vid> <pid> <lo_rev> <hi_rev> UQ_MSC_IGNORE'.

Reviewed by: imp
MFC After: 1 week
Pull Request: https://github.com/freebsd/freebsd-src/pull/1716
Closes: https://github.com/freebsd/freebsd-src/pull/1716

Details

Provenance
Jan Biedermann <jan@isomorfeus.com>Authored on Jun 6 2025, 1:38 PM
impCommitted on Jun 11 2025, 11:16 PM
Parents
rG37983aef7c70: Add quiet/-q option to /usr/sbin/service
Branches
Unknown
Tags
Unknown