HomeFreeBSD

module: freebsd: avoid a taking a destroyed lock in zfs_zevent bits

Description

module: freebsd: avoid a taking a destroyed lock in zfs_zevent bits

At shutdown time, we drain all of the zevents and set the
ZEVENT_SHUTDOWN flag. On FreeBSD, we may end up calling
zfs_zevent_destroy() after the zevent_lock has been destroyed while
the sysevent thread is winding down; we observe ESHUTDOWN, then back
out.

Events have already been drained, so just inline the kmem_free call in
sysevent_worker() to avoid the race, and document the assumption that
zfs_zevent_destroy doesn't do anything else useful at that point.

This fixes a panic that can occur at module unload time.

Reviewed-by: Ryan Moeller <freqlabs@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Kyle Evans <kevans@FreeBSD.org>
Closes #13220

Details

Provenance
kevansAuthored on Mar 17 2022, 5:14 PM
GitHub <noreply@github.com>Committed on Mar 17 2022, 5:14 PM
Parents
rG6ef00196db1c: module: zstd: check we don't leak symbols; regenerate symbol map
Branches
Unknown
Tags
Unknown